feat(atlassian): resolve dynamic scopes and index Confluence attachments by waleedlatif1 · Pull Request #7935 · simstudioai/sim

waleedlatif1 · 2026-09-17T18:56:25Z

Summary

Resolve Confluence and Jira All selections against the syncing account's current access. Preserve explicit selections and existing saved scopes; reject mixed All/explicit values before saving or querying.
Store large Confluence space audiences as bounded groups while preserving parent restrictions, reader identity, tenant isolation, freshness, and revocations.
Index PDF and Word attachments through the existing parsing pipeline with parent permissions, bounded downloads, and safe redirects. Missing attachment scope reports a partial sync while existing page connections keep working.
Update the connector guides. No schema migration is required.

Type of Change

Bug fix and feature improvement

Testing

3,956 knowledge, search, connector, access, selector, credential, and processing regression tests passed after rebasing onto staging.
95 disposable PostgreSQL tests passed, covering large audiences, concurrent revocations, cross-account isolation, large token queries, sync continuation, partition scheduling, and lifecycle locks. The 52 Confluence/access cases also run in both CI database provisioning variants.
Application type-check, full lint, all 46 repository audits (including API boundary validation), block registry, docs manifest, and migration checks passed.
Actual PDF and DOCX parser round trips are covered; live-provider attachment validation remains a deployment check.

Rollout: deploy the updated readers and prune protection, and drain old connector/directory runs before starting the new audience writers. App-before-worker promotion alone does not stop already-running old jobs from pruning the new audience records. Attachment indexing requires the documented attachment scope; previously saved selection snapshots require reselecting All to become dynamic.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-17T18:56:31Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 17, 2026 7:50pm UTC

greptile-apps · 2026-09-17T19:00:28Z

Confidence Score: 4/5

The PR is not yet safe to merge because ambiguous Google 403 responses can conceal connector-wide credential or scope failures behind indefinite per-user retries.

Summary

This PR expands Atlassian connector behavior with dynamic “All” scopes, Confluence attachment indexing, bounded audience groups, and associated access-control and sync changes. Changes added since the previous review also introduce durable per-user Google connector scheduling, document-processing queue lanes, stricter durable secret-provenance enforcement, and supporting database and CI coverage.

Resolves dynamic Jira and Confluence scopes against current provider access.
Indexes supported Confluence attachments while inheriting parent permissions and preserving partial-sync safety.
Adds durable connector partition work and per-user Google crawl scheduling.
Separates interactive and backfill document-processing queues.
Extends tests, documentation, schema metadata, and PostgreSQL integration coverage.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Directory discovery] --> B[Durable per-user partitions]
  B --> C[Content listing]
  B --> D[Permission refresh]
  C --> E{Provider result}
  D --> E
  E -->|Success| F[Commit cursor and documents]
  E -->|Known user-specific 403| G[Defer partition with retry]
  E -->|Connector-wide failure| H[Surface connector error]
  F --> I{All partitions complete?}
  G --> I
  I -->|No| B
  I -->|Yes and safe| J[Reconcile removals]

_{Reviews (4) · Last reviewed commit: "fix(ci): isolate Confluence migration te..."}

cubic-dev-ai

All reported issues were addressed across 45 files

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-17T19:19:29Z

@greptile

waleedlatif1 · 2026-09-17T19:19:30Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-17T19:19:37Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-17T19:26:06Z

@greptile

waleedlatif1 · 2026-09-17T19:26:07Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-17T19:26:18Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-17T19:44:05Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-17T19:44:11Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 48 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

waleedlatif1 · 2026-09-17T19:48:56Z

@greptile

waleedlatif1 · 2026-09-17T19:48:57Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-17T19:49:03Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 48 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

vercel Bot deployed to Preview September 17, 2026 18:58 View deployment

cubic-dev-ai Bot reviewed Sep 17, 2026

View reviewed changes

Comment thread apps/sim/lib/knowledge/connectors/sync-engine.ts

Comment thread apps/sim/connectors/jira/meta.ts

Comment thread apps/sim/lib/knowledge/access/group-membership.integration.ts

vercel Bot deployed to Preview September 17, 2026 19:17 View deployment

greptile-apps Bot reviewed Sep 17, 2026

View reviewed changes

Comment thread .github/workflows/test-build.yml

vercel Bot deployed to Preview September 17, 2026 19:27 View deployment

waleedlatif1 added 3 commits September 17, 2026 12:46

feat(atlassian): resolve dynamic scopes and index Confluence attachments

6c8e5a8

fix(atlassian): reject mixed All scopes and run permission tests in CI

822c331

fix(ci): isolate Confluence migration test database

b803a36

cubic-dev-ai Bot reviewed Sep 17, 2026

View reviewed changes

waleedlatif1 force-pushed the codex/atlassian-sync-scope branch from 7e38379 to b803a36 Compare September 17, 2026 19:48

waleedlatif1 merged commit 0b893d7 into staging Sep 17, 2026
20 of 22 checks passed

waleedlatif1 deleted the codex/atlassian-sync-scope branch September 17, 2026 19:48

vercel Bot deployed to Preview September 17, 2026 19:50 View deployment

cubic-dev-ai Bot reviewed Sep 17, 2026

View reviewed changes

waleedlatif1 mentioned this pull request Sep 17, 2026

v0.8.42: knowledgebase queueing improvemnets, file search time fixes, outbox fixes #7945

Merged

mzxchandra mentioned this pull request Sep 20, 2026

feat(confluence): index PowerPoint and Excel attachments #8050

Merged

6 tasks

Conversation

waleedlatif1 commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Summary

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 17, 2026

Uh oh!

waleedlatif1 commented Sep 17, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 17, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Sep 17, 2026

Uh oh!

waleedlatif1 commented Sep 17, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 17, 2026

Uh oh!

waleedlatif1 commented Sep 17, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 17, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 17, 2026

Uh oh!

waleedlatif1 commented Sep 17, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 17, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Sep 17, 2026 •

edited

Loading

vercel Bot commented Sep 17, 2026 •

edited

Loading

greptile-apps Bot commented Sep 17, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading