feat(confluence): index PowerPoint and Excel attachments - #8050
Merged
Merged
Conversation
Extend the Confluence attachment allowlist so .pptx and .xlsx files on synced pages and blog posts are listed and handed to the shared parser pipeline the same way PDF and Word attachments already are. Macro-enabled, template, legacy binary and OpenDocument variants stay excluded. Add listing, hydration, genuine-bytes roundtrip and renamed-to-unsupported coverage, and update the connector guides to name the new formats.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
Contributor
|
@mzxchandra I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #7935 indexes PDF and Word attachments on Confluence pages and blog posts as separate knowledge-base documents. PowerPoint and Excel attachments on the same pages were still dropped silently at listing time, even though the shared parser pipeline already handles them.
pptxandxlsxto the Confluence attachment allowlist inconnectors/confluence/attachments.ts. The set stays a deliberate Confluence-local subset ofPIPELINE_PARSED_MIME_TYPES: macro-enabled, template, legacy binary (.xls,.ppt) and OpenDocument variants remain excluded.knowledgebase/connectors.mdx,search/confluence.mdx) to list the new formats, the conversion advice for.xls/.ppt, and that already-connected spaces pick the formats up on their next sync.No
contentHashchange is needed: ineligible attachments never produced a row, and Confluence re-lists every attachment each sync, so a newly eligible file arrives as a new document on the next run.Type of Change
Testing
Unit (
connectors/confluence/attachments.test.ts, extended in place):.pptx/.xlsxstubs with the pipeline MIME types and excludes.pptm,.xls,.ppt, images and archived filespdf,doc,docx,pptx,xlsx.ppt/.xlsafter listing hydrates as a replace-skip without downloading200 tests pass across the three Confluence-related files;
type-check,lint(sim and docs) andcheck:api-validationpass.End to end on a local build against a Confluence Cloud test site, with a seeded page carrying
Onboarding Guide.pdf,Roadmap Deck.pptx,Budget Tracker.xlsxandOld Deck.ppt:Onboarding Guide.pdfonlyRoadmap Deck.pptx, +Budget Tracker.xlsx;.pptstill excluded (2 added, 0 deleted)Stored objects are byte-identical to the uploaded files and keyed with their real extensions. After processing,
sim knowledge search --kbreturned the deck's chunk as the top hit for a sentence only the deck contains, and the spreadsheet's chunk for a sentence only the spreadsheet contains.Reviewers: the wording in the two docs pages and the
FILE_EXTENSIONSTSDoc are the judgement calls.Checklist
🤖 Generated with Claude Code