Skip to content

fix(knowledge): preserve permission notices and fixture isolation - #7926

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/coda-review-followup
Sep 17, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/coda-review-followup

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve permission warnings in the organization overview when sync notices are combined, matching the source detail page.
  • Normalize Coda fixture identities before sharing mutations, and cover the guards and composed notices with regression tests.
  • Run the organization overview PostgreSQL suite in CI and align its queued-sync expectations with the existing response contract.

Type of Change

  • Bug fix

Testing

78 unit/UI tests and 13 real PostgreSQL tests pass. App type checking, lint, all 46 repository audits, and generated-artifact checks pass. The eight cleanup passes found no issues. Live Coda mutations were not rerun for this fixture-guard change.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 17, 2026 8:06am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the latest changes make the PostgreSQL fixtures more deterministic without introducing a new correctness or rule-compliance issue.

Summary

This PR improves knowledge-connector operational reporting and live Coda fixture safety.

  • Recognizes exact, line-delimited permission notices within composed synchronization diagnostics while avoiding substring false positives.
  • Normalizes Coda fixture identities before allowing live sharing mutations.
  • Adds regression coverage for permission-notice composition, paused connectors, fixture isolation, and queued synchronization states.
  • Adds the organization overview PostgreSQL integration suite to CI.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Connector synchronization diagnostics] --> B{Paused?}
  B -->|Yes| C[Ignore operational permission notice]
  B -->|No| D[Split diagnostics into lines]
  D --> E{Exact permission notice present?}
  E -->|Yes| F[needs_attention: permission_sync_incomplete]
  E -->|No| G[Evaluate other synchronization failures]
  H[Coda live-sharing test] --> I[Fetch document name and owner]
  I --> J[Normalize owner and second identity]
  J --> K{Expected fixture name and distinct identities?}
  K -->|No| L[Refuse sharing mutation]
  K -->|Yes| M[Allow fixture mutation]
Loading

Reviews (3) · Last reviewed commit: "fix(knowledge): make healthy sync fixtur..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 12224be into staging Sep 17, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/coda-review-followup branch September 17, 2026 08:19

This branch was previously deployed

1 inactive deployment
Preview 99eda3c2 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant