Skip to content

v0.8.41: library, coda connector, connector sync engine hardening - #7922

Merged
waleedlatif1 merged 11 commits into
mainfrom
staging
Sep 17, 2026
Merged

waleedlatif1 merged 11 commits into
mainfrom
staging

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

waleedlatif1 and others added 7 commits September 16, 2026 21:31
* fix(http): substitute path parameters only by their whole name

The HTTP request tool replaced each path parameter with a plain string
replace of `:${key}` over the whole URL. An empty key stripped the colon
from the scheme, so `https://host` became `https//host` and the request
was refused as not absolute; a numeric key rewrote the port into the host;
and `:id` matched inside `:idx`. Models occasionally send an empty
path-parameter entry, which made agent API tool calls fail intermittently.

Substitute a key only when it starts like a JavaScript identifier, as
path-to-regexp defines `:name` parameters, and end each placeholder where
an identifier ends.

* fix(http): prefer the longest path parameter key and accept Unicode identifiers
* feat(coda): add permission-aware knowledge connector

* fix(coda): refine setup docs and verification coverage

* fix(coda): clarify workspace access in setup guide
…cal Roundup (#7919)

Co-authored-by: Sim Pi Agent <pi@sim.ai>
* docs(library): update n8n-alternatives

* Pi Babysit: address PR #7921 feedback

---------

Co-authored-by: Sim Pi Agent <pi@sim.ai>
* fix(knowledge): bound permission pagination and member cleanup

* fix(knowledge): retain permission notices alongside member errors
@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 17, 2026 8:21am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no concrete correctness, security, or repository-rule violation remains.

Summary

This PR adds a permission-aware Coda connector and supporting documentation, strengthens connector pagination, directory synchronization, Google Workspace failure isolation, document lifecycle processing, and embedding writes, changes Insights to default to 30 days, and updates library content.

  • Registers Coda for workspace and organization Search with bounded listing, deferred hydration, source ACL mirroring, and Enterprise directory support.
  • Persists bounded per-user Google listing failures so unaffected users continue syncing without unsafe deletion reconciliation.
  • Hardens Confluence permission pagination and external-group synchronization against partial, repeated, or stale provider results.
  • Batches embedding inserts and member-document lifecycle writes while retaining transaction and lease guards.
  • Fixes HTTP path-parameter substitution so only complete parameter names are replaced.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Connector sync starts] --> B[Refresh mirrored directory]
    A --> C[List source documents]
    B --> D{Directory complete?}
    D -->|Yes| E[Replace verified memberships]
    D -->|Partial| F[Keep failed groups stale and record warning]
    C --> G[Persist listing checkpoint]
    G --> H[Hydrate changed content]
    H --> I[Resolve source ACLs]
    I --> J{Permissions verified?}
    J -->|Yes| K[Persist ACLs]
    J -->|No| L[Fail closed and record incomplete permissions]
    K --> M[Reconcile missing documents if listing is authoritative]
    L --> N[Hold deletion reconciliation]
    F --> N
    M --> O[Complete sync]
    N --> O
Loading

Reviews (1) · Last reviewed commit: "fix(search): isolate Google crawl failur..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 69 files

Confidence score: 3/5

  • apps/sim/connectors/google-workspace/api-errors.ts can treat a matching Calendar events.list error with no reason entries as universally forbidden, suppressing 403 failures that may have other causes and misleading callers about the underlying error. Ensure reasonsComplete is only set when reasons are actually present or preserve the original error when the list is empty.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/connectors/google-workspace/api-errors.ts">

<violation number="1" location="apps/sim/connectors/google-workspace/api-errors.ts:89">
P2: When a Calendar `events.list` response has a matching `code` but no reason entries, this marks `reasonsComplete` true. `userListingFailure` then treats the empty array as all `forbidden` and suppresses any 403, including global failures; require a nonempty `forbidden` reason before isolating the user.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/connectors/coda/coda.ts
Comment thread apps/sim/connectors/google-workspace/api-errors.ts
Comment thread apps/sim/lib/knowledge/__integration__/coda-live.integration.ts Outdated
…n Platforms (#7925)

Co-authored-by: Sim Pi Agent <pi@sim.ai>
* fix(search): require explicit Calendar access failure reasons

* fix(search): align Calendar connector regression coverage
)

* fix(knowledge): preserve permission notices and fixture isolation

* fix(knowledge): make healthy sync fixtures explicit
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic review

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 75 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 3c8a4c4 into main Sep 17, 2026
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants