Skip to content

fix(search): require explicit Calendar access failure reasons - #7924

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/calendar-error-classification
Sep 17, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/calendar-error-classification

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Require an explicit forbidden reason before isolating a Calendar event-listing 403 to one user. Responses without reason codes now propagate through the existing failure path.
  • Add regression coverage for missing and empty reason lists, preserve explicit-forbidden partial crawls, and align the Calendar documentation.

Type of Change

  • Bug fix

Testing

  • Reproduced three failing regression cases before the fix.
  • 710 tests across all Google connector suites and sync reconciliation passed.
  • Repository lint, all 46 audits (including API boundary validation), documentation checks, and app type-check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 17, 2026 7:55am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the narrowed failure-isolation predicate, regression coverage, and documentation consistently enforce the intended behavior.

Summary

This PR narrows per-user Google Calendar failure isolation to 403 responses containing at least one explicit forbidden reason.

  • Propagates unclassified Calendar 403 responses through the existing crawl failure path.
  • Preserves partial crawling for explicit forbidden access failures.
  • Adds regression coverage for missing, empty, and explicit reason lists.
  • Updates Calendar documentation to describe the revised behavior.

Reviews (2) · Last reviewed commit: "fix(search): align Calendar connector re..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 3060a84 into staging Sep 17, 2026
34 of 35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/calendar-error-classification branch September 17, 2026 08:19

This branch was previously deployed

1 inactive deployment
Preview 4b10b396 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant