-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(gmail): open search results in the indexed mailbox #7910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| /** @vitest-environment node */ | ||
| import { beforeEach, describe, expect, it, vi } from 'vitest' | ||
| import { getGmailMailboxEmail, getGmailProfile, gmailThreadUrl } from '@/connectors/gmail/mailbox' | ||
|
|
||
| const { transport } = vi.hoisted(() => ({ transport: vi.fn<typeof fetch>() })) | ||
| vi.mock('@/lib/knowledge/documents/secure-fetch.server', () => ({ | ||
| fetchWithRetry: ( | ||
| url: string, | ||
| init: RequestInit, | ||
| options: { | ||
| fetcher: (url: string, init: RequestInit, transport: typeof fetch) => Promise<Response> | ||
| } | ||
| ) => options.fetcher(url, init, transport), | ||
| })) | ||
|
|
||
| beforeEach(() => { | ||
| transport.mockReset() | ||
| transport.mockResolvedValue( | ||
| Response.json({ emailAddress: 'Alice+work@example.com', historyId: '123' }) | ||
| ) | ||
| }) | ||
|
|
||
| describe('Gmail mailbox identity', () => { | ||
| it('selects the authenticated mailbox before an archived-thread fragment', async () => { | ||
| const email = await getGmailMailboxEmail('mailbox-token', {}) | ||
| const url = new URL(gmailThreadUrl('19a3f0123456789', email)) | ||
| expect(url.origin).toBe('https://accounts.google.com') | ||
| expect(url.pathname).toBe('/AccountChooser') | ||
| expect(url.searchParams.get('Email')).toBe('alice+work@example.com') | ||
| expect(url.hash).toBe('') | ||
| const destination = new URL(url.searchParams.get('continue')!) | ||
| expect(destination.origin).toBe('https://mail.google.com') | ||
| expect(destination.pathname).toBe('/mail/') | ||
| expect(destination.searchParams.get('authuser')).toBe('alice+work@example.com') | ||
| expect(destination.hash).toBe('#all/19a3f0123456789') | ||
| expect(transport).toHaveBeenCalledWith( | ||
| 'https://gmail.googleapis.com/gmail/v1/users/me/profile?fields=emailAddress,historyId', | ||
| expect.objectContaining({ | ||
| headers: expect.objectContaining({ Authorization: 'Bearer mailbox-token' }), | ||
| }) | ||
| ) | ||
| }) | ||
|
|
||
| it('deduplicates concurrent lookups and reuses the profile read for the history watermark', async () => { | ||
| const context = {} | ||
| expect( | ||
| await Promise.all(Array.from({ length: 100 }, () => getGmailMailboxEmail('token', context))) | ||
| ).toEqual(Array(100).fill('alice+work@example.com')) | ||
| expect(transport).toHaveBeenCalledTimes(1) | ||
| transport.mockResolvedValue( | ||
| Response.json({ emailAddress: 'alice+work@example.com', historyId: '456' }) | ||
| ) | ||
| expect((await getGmailProfile('token', context)).historyId).toBe('456') | ||
| expect(await getGmailMailboxEmail('token', context)).toBe('alice+work@example.com') | ||
| expect(transport).toHaveBeenCalledTimes(2) | ||
| }) | ||
|
|
||
| it('seeds mailbox identity from a fresh watermark without a second request', async () => { | ||
| const context = {} | ||
| await getGmailProfile('token', context) | ||
| await getGmailMailboxEmail('token', context) | ||
| expect(transport).toHaveBeenCalledTimes(1) | ||
| }) | ||
|
|
||
| it('isolates credentials even if the same context is mistakenly reused', async () => { | ||
| const context = {} | ||
| await getGmailMailboxEmail('alice-token', context) | ||
| transport.mockImplementation(async () => | ||
| Response.json({ emailAddress: 'bob@example.com', historyId: '321' }) | ||
| ) | ||
| expect(await getGmailMailboxEmail('bob-token', context)).toBe('bob@example.com') | ||
| await getGmailMailboxEmail('bob-token', {}) | ||
| expect(transport).toHaveBeenCalledTimes(3) | ||
| }) | ||
|
|
||
| it.each([ | ||
| {}, | ||
| { emailAddress: '', historyId: '1' }, | ||
| { emailAddress: 'not-an-email', historyId: '1' }, | ||
| { emailAddress: 'alice@example.com', historyId: 123 }, | ||
| { emailAddress: 'alice@example.com', historyId: 'invalid' }, | ||
| ])('rejects malformed profiles instead of falling back to account zero: %j', async (body) => { | ||
| transport.mockResolvedValue(Response.json(body)) | ||
| await expect(getGmailMailboxEmail('token', {})).rejects.toThrow('malformed profile') | ||
| }) | ||
|
|
||
| it('does not cache a failed lookup', async () => { | ||
| transport.mockResolvedValueOnce(Response.json({})) | ||
| const context = {} | ||
| await expect(getGmailMailboxEmail('token', context)).rejects.toThrow() | ||
| expect(await getGmailMailboxEmail('token', context)).toBe('alice+work@example.com') | ||
| }) | ||
|
|
||
| it('preserves provider authentication errors and cancellation', async () => { | ||
| transport.mockResolvedValueOnce(new Response(null, { status: 401 })) | ||
| await expect(getGmailMailboxEmail('invalid', {})).rejects.toMatchObject({ status: 401 }) | ||
| const controller = new AbortController() | ||
| controller.abort() | ||
| await expect(getGmailProfile('token', { signal: controller.signal })).rejects.toThrow() | ||
| expect(transport).toHaveBeenCalledTimes(1) | ||
| }) | ||
|
|
||
| it('bounds profile responses', async () => { | ||
| transport.mockResolvedValue(Response.json({ padding: 'x'.repeat(17 * 1024) })) | ||
| await expect(getGmailMailboxEmail('token', {})).rejects.toThrow() | ||
| }) | ||
|
|
||
| it('encodes fragment delimiters rather than allowing them to change the link target', () => { | ||
| const chooser = new URL(gmailThreadUrl('thread/?#id', 'alice@example.com')) | ||
| expect(new URL(chooser.searchParams.get('continue')!).hash).toBe('#all/thread%2F%3F%23id') | ||
| }) | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.