Skip to content

fix(gmail): open search results in the indexed mailbox - #7910

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/gmail-search-account-links
Sep 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/gmail-search-account-links

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Open Gmail search results in the indexed mailbox, including when that account is not signed in to the browser.
  • Resolve mailbox identity from Gmail credentials and reuse it within each sync. Keep history cursors fresh and preserve document content, hashes, and access controls.
  • Exclude repair scripts and database backfills; existing stored links are unchanged.

Type of Change

  • Bug fix

Testing

  • 190 connector, Google Workspace, and citation tests passed.
  • 7 PostgreSQL ingestion and access-control integration tests passed with provider fixtures.
  • Verified live browser navigation for a signed-in secondary mailbox and an account not signed in.
  • App type-check, repository lint, all 46 audits (including strict API validation), block registry, and docs manifest checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 17, 2026 2:17am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no new actionable issues and the earlier historical-link limitation explicitly accepted and manually resolved.

Summary

This PR makes Gmail knowledge-search results open in the mailbox that was indexed rather than defaulting to browser account zero.

  • Resolves and validates the authenticated mailbox email from the Gmail profile.
  • Reuses mailbox identity within a sync while keeping history watermarks fresh.
  • Builds account-chooser URLs that target the correct mailbox and archived thread.
  • Adds unit, connector, citation, and PostgreSQL integration coverage.
  • Deliberately leaves unchanged historical stored links for a separate repair or metadata-reconciliation effort.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Gmail credential] --> B[Read Gmail profile]
  B --> C[Validate mailbox email and history ID]
  C --> D[Cache mailbox identity for current sync]
  D --> E[Create thread document stub]
  E --> F[Build Google AccountChooser URL]
  F --> G[Open indexed mailbox]
  G --> H[Open Gmail thread under all mail]
Loading

Reviews (2) · Last reviewed commit: "fix(gmail): open search results in the i..."

Comment thread apps/sim/connectors/gmail/gmail.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 32d98f4 into staging Sep 17, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/gmail-search-account-links branch September 17, 2026 02:31

This branch was previously deployed

1 inactive deployment
Preview fbe8a76d Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant