Skip to content

fix(search): preserve source rows during approval updates - #7731

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/source-toggle-cache-refresh
Sep 10, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/source-toggle-cache-refresh

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the administrative Sources overview visible while a source is enabled or disabled. The permission-cache reset previously discarded this query and briefly replaced every row with a loading state.
  • Refresh that exact overview separately while continuing to clear permission-sensitive source lists, Search results, and document content.

Type of Change

  • Bug fix

Testing

  • Reproduced the list remount in the UI and verified row identity stays stable after the fix.
  • Added real QueryObserver regression coverage for successful and failed refreshes, preservation of other organizations' caches, and clearing viewer data. Both new cases fail on the previous code.
  • All 48 related tests pass, including existing request-cancellation guards. All eight cleanup passes, full lint, typecheck, and pre-ship audits pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 10, 2026 10:43am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the cache-key exclusion and refresh behavior aligned with the intended administrative UI lifecycle.

Summary

  • Excludes the organization’s administrative overview from the broader viewer-cache reset.
  • Separately invalidates that overview while continuing to clear permission-sensitive source lists, search results, and document data.
  • Adds QueryObserver coverage for successful and failed refreshes, cross-organization isolation, and continued viewer-data cleanup.

Reviews (1) · Last reviewed commit: "fix(search): preserve source rows during..."

@waleedlatif1
waleedlatif1 merged commit c5e65a0 into staging Sep 10, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/source-toggle-cache-refresh branch September 10, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant