Skip to content

desk: run the desk as a sub-agent of the Shell, drop the Agent tab - #26

Merged
simoncrypta merged 1 commit into
masterfrom
desk-one-agent
Nov 1, 2026
Merged

simoncrypta merged 1 commit into
masterfrom
desk-one-agent

Conversation

@simoncrypta

Copy link
Copy Markdown
Owner

Summary

Since #25 each desk agent was drawn twice: once in the bercail layout's sticky desk column (desk-<address> block) and once as a pane in a tab of its own ("Agent"), because both start paths labelled it herdr.space. Same terminal, two views.

  • bercail/mods/bercail-desk/main.js: start() runs the desk as hc run --bg --json --keep --outlive-parent --no-notify --parent <shellOf(space)> ... with bercail.role / bercail.space labels and no herdr.space; the "no Shell terminal" warning is back; the "Agent" tab rename is gone; the desk header falls back to the terminal's title.
  • config/worktrunk/herdr-layout.sh: _wt_herdr_space_shell (first terminal of tabs[0] from herdr-app ls); _wt_herdr_start_desk starts the desk under it and fails if the space has no Shell.
  • Docs (README, RECIPE, handoff resources, bin/bercail-desk-agent comment) and tests updated.

Known gap: Herdr's shipped agents list only shows sub-agents under a listed agent, so a desk under a bash Shell isn't listed there. Tracked separately as bercail-dwo.

Council verdict

bstack council (Claude, GPT, Grok; 1 round): no blocker or major. GPT found nothing; Claude flagged two stale doc lines (README.md:15, bin/bercail-desk-agent:8), fixed; Grok flagged the blank desk header title, fixed with a terminals() title fallback. Unslop removed three redundant test assertions.

Test evidence

  • All 24 tests/*.sh pass locally.
  • herdr-app check bercail/mods/bercail-desk passes.
  • shellcheck: no new findings on the changed shell files (same counts as master).
  • Live (desk agent): new worktree via wt switch --create gives one bercail.role=agent terminal under the Shell's sub_agents, no Agent tab; same for Ctrl+Shift+A (mod start()) and the handoff path.

Closes bercail-3z6

Since #25 every desk was drawn twice: in the sticky desk column and in a tab of its own (herdr.space label). Start it again as a sub-agent of the space's Shell (--parent <shell> --outlive-parent, no herdr.space) from both the desk mod and herdr-layout.sh, drop the Agent tab rename, and fall back to the terminal title in the desk header. Docs and tests follow.
@simoncrypta
simoncrypta merged commit d712e53 into master Nov 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant