Repository navigation
desk: run the desk as a sub-agent of the Shell, drop the Agent tab - #26
Merged
Merged
Conversation
Since #25 every desk was drawn twice: in the sticky desk column and in a tab of its own (herdr.space label). Start it again as a sub-agent of the space's Shell (--parent <shell> --outlive-parent, no herdr.space) from both the desk mod and herdr-layout.sh, drop the Agent tab rename, and fall back to the terminal title in the desk header. Docs and tests follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #25 each desk agent was drawn twice: once in the bercail layout's sticky desk column (
desk-<address>block) and once as a pane in a tab of its own ("Agent"), because both start paths labelled itherdr.space. Same terminal, two views.bercail/mods/bercail-desk/main.js:start()runs the desk ashc run --bg --json --keep --outlive-parent --no-notify --parent <shellOf(space)> ...withbercail.role/bercail.spacelabels and noherdr.space; the "no Shell terminal" warning is back; the "Agent" tab rename is gone; the desk header falls back to the terminal's title.config/worktrunk/herdr-layout.sh:_wt_herdr_space_shell(first terminal oftabs[0]fromherdr-app ls);_wt_herdr_start_deskstarts the desk under it and fails if the space has no Shell.bin/bercail-desk-agentcomment) and tests updated.Known gap: Herdr's shipped agents list only shows sub-agents under a listed agent, so a desk under a bash Shell isn't listed there. Tracked separately as bercail-dwo.
Council verdict
bstack council (Claude, GPT, Grok; 1 round): no blocker or major. GPT found nothing; Claude flagged two stale doc lines (README.md:15, bin/bercail-desk-agent:8), fixed; Grok flagged the blank desk header title, fixed with a
terminals()title fallback. Unslop removed three redundant test assertions.Test evidence
tests/*.shpass locally.herdr-app check bercail/mods/bercail-deskpasses.wt switch --creategives onebercail.role=agentterminal under the Shell'ssub_agents, no Agent tab; same for Ctrl+Shift+A (modstart()) and the handoff path.Closes bercail-3z6