Repository navigation
desk: list each desk in the agents list with a bercail copy of Herdr's agents mod - #27
Merged
Merged
Conversation
…s agents mod Herdr's shipped agents mod draws sub-agents only under a listed agent, so a desk under a bash Shell had no row. bercail-agents is a mod.clone of it plus deskRows/withDesks: each live bercail.role=agent terminal that neither agents() nor a listed parent covers gets a top-level row with its terminals() status; a click runs bercail-desk.agent:<desk>. The bercail layout uses it, install/uninstall handle both mods, and docs/herdr-agents-subagents.md has the upstream proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #26 the desk is a sub-agent of the space's bash Shell. Herdr's shipped
agentsmod only draws sub-agents as child rows under an agent that is already inagents()(mods/agents/main.jstree()/withKids), and a bash Shell never is, so desks had no row in the agents list.bercail/mods/bercail-agents/:herdr-app do mod.clone '{"name":"agents","as":"bercail-agents"}'of the shipped mod (0.1.11), plus a small addition:deskRows()gives every livebercail.role=agentterminal that isn't inagents()and whose parent isn't either a top-level row, with itsterminals()status (read likekidStatus);withDesks()puts it first among its space's agents; a click runsbercail-desk.agent:<desk>. Against the shipped mod the diff is only those functions, a header comment, two lines inrender()and the twoon_clicks.bercail/mods/bercail-desk: theagentcommand focuses the desk throughfocusAgent(selects the desk's space and its desk block first).bercail/layouts/bercail.json: the agents block usesbercail-agents.lib/config.shinstalls andherdr-app checks both mods;lib/uninstall.shremoves both.docs/herdr-agents-subagents.md: written proposal and patch for Herdr's shipped agents mod (list sub-agents whose ancestors aren't agents). Not filed upstream.tests/agents_mod_test.sh.Review
No bstack council ran on this one (desk run overnight). Reviewed by Shep: confirmed the mod is the shipped
agentsmod plus the additions above (diffed against~/.config/herdr-app/mods/agents/main.js); no shipped mod edited in place; space changes only on a click.Test evidence
tests/*.shpass locally;tests/agents_mod_test.shfails against the shipped mod ("a Shell sub-agent desk has no row") and passes with the clone.herdr-app checkpasses forbercail-deskandbercail-agents.deskRows/withDesksrun against livehc get+herdr-app lsdata give rows for desks t72 (Desk-agents-row_Bercail, under Shell t71), t2x (RedwoodGQL) and t46, plus the pane agents. The live app runs the layout withbercail-agentsand reports no errors. Not watched on screen (the window wasn't drawing forherdr-app shot), so the on-screen working -> idle row is left to check by eye.Closes bercail-dwo