Skip to content

[4c] Delete the WebView write path #455

Open

Description

@imnasnainaec

Part of Phase 4 (#427) of the data layer plan.

Delete the old path: WebView reducers, parity tests, whole-draft getDraft/saveDraft, snapshot undo, the WebView reanchor passes, the Stale filter's "(found when a book is opened)" qualifier, the source-project form of getBookOutline, getSegments, getTextReadStatus and onAnalysisChanged, and the breach report on project Save.

Done when: nothing references the deleted code, and e2e tests pass.

Depends on: 4b (#454).

From the plan

Performance checkpoint

After What to check Baseline (large-loadable)
4c WebView heap with a full undo history, and host heap WebView +1,401 MB; host +177 MB

Activity

  1. imnasnainaec commented on Oct 19, 2026

    @imnasnainaec
    ContributorAuthor

    From #431: delete the perf spec's autosave wait (unsavedFrame, waitForAutosave, settleAutosave, closeSettledView) along with the debounced autosave. What remains to assume is that no command is in flight when a view closes. The edit scenario already waits for each reply to render.

  2. imnasnainaec commented on Oct 20, 2026

    @imnasnainaec
    ContributorAuthor

    Delete the source-project form of getTextReadStatus (interlinearizer.getTextReadStatus and bookService.getTextReadStatus(sourceProjectId)).

    isFormInText is addressed by source project too.

  3. imnasnainaec commented on Oct 21, 2026

    @imnasnainaec
    ContributorAuthor

    From #432: removing exportAll and replaceAll removes most conformance tests. Rewrite them against the replacement reads rather than deleting them.

  4. imnasnainaec commented on Oct 21, 2026

    @imnasnainaec
    ContributorAuthor

    ⛏️ Deleting the whole-draft saveDraft also deletes #475's handling of draft books whose stored analysis can't be read (see its "Unreadable draft books" section), including discardUnreadable, which useDraftProject's started-over flag sets. The host path needs the same behaviour before this lands. The natural home is the whole-scope change in 3a (#440) and 3b (#441): opening a session, New and Open.

  5. alex-rawlings-yyc commented on Oct 23, 2026

    @alex-rawlings-yyc
    Contributor

    From #486: neither 3a nor 3b has the discardUnreadable handling. It belongs with host New and Open, which start the draft over, rather than with opening a session, which only loads; main likewise sets it only on saves that start the draft over. No issue owns host New or Open yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions