Skip to content

fix: status bar and gesture nav icons follow the reading page, not the app theme #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schmitzkr merged 1 commit into from
Sep 8, 2026
Merged

fix: status bar and gesture nav icons follow the reading page, not the app theme #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion app/src/main/kotlin/com/schmitzkr/grimreader/ui/reader/EpubReaderScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,9 +432,27 @@ fun EpubReaderScreen(
controller.systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
if (chrome) controller.show(WindowInsetsCompat.Type.systemBars()) else controller.hide(WindowInsetsCompat.Type.systemBars())
}
// The status bar and gesture nav bar are transparent and sit directly over
// the page background (not over ReaderBar's own themed pill), so their
// icon color needs to track whatever the reading theme actually shows,
// not the app's own light/dark setting -- a light appearance (dark icons)
// stayed on top of a black reading page otherwise.
LaunchedEffect(state.theme) {
val window = (view.context as? Activity)?.window ?: return@LaunchedEffect
val pageIsLight = state.theme == "light" || state.theme == "sepia"
WindowCompat.getInsetsController(window, view).apply {
isAppearanceLightStatusBars = pageIsLight
isAppearanceLightNavigationBars = pageIsLight
}
}
DisposableEffect(Unit) {
onDispose {
(view.context as? Activity)?.window?.let { WindowCompat.getInsetsController(it, view).show(WindowInsetsCompat.Type.systemBars()) }
(view.context as? Activity)?.window?.let { window ->
val controller = WindowCompat.getInsetsController(window, view)
controller.show(WindowInsetsCompat.Type.systemBars())
controller.isAppearanceLightStatusBars = !dark
controller.isAppearanceLightNavigationBars = !dark
}
}
}

Expand Down
22 changes: 21 additions & 1 deletion app/src/main/kotlin/com/schmitzkr/grimreader/ui/reader/PageReaderScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import androidx.compose.animation.fadeIn
import androidx.compose.animation.fadeOut
import androidx.compose.foundation.Image
import androidx.compose.foundation.background
import androidx.compose.foundation.isSystemInDarkTheme
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
Expand Down Expand Up @@ -255,6 +256,7 @@ fun PageReaderScreen(
var chrome by remember { mutableStateOf(true) }
var zoomed by remember { mutableStateOf(false) }
val scope = rememberCoroutineScope()
val dark = isSystemInDarkTheme()
val view = LocalView.current
val exit = { vm.exit(onBack) }
BackHandler { exit() }
Expand All @@ -269,9 +271,27 @@ fun PageReaderScreen(
controller.systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
if (chrome) controller.show(WindowInsetsCompat.Type.systemBars()) else controller.hide(WindowInsetsCompat.Type.systemBars())
}
// The status bar and gesture nav bar sit directly over the page (always
// black for comics, night-mode-dependent for PDF), not over ReaderBar's
// own themed pill, so their icon color needs to track the page, not the
// app's own light/dark setting -- a light appearance (dark icons) stayed
// on top of an always-black comic page otherwise.
LaunchedEffect(state.night, format) {
val window = (view.context as? Activity)?.window ?: return@LaunchedEffect
val pageIsLight = !state.night && format != PageFormat.CBX
WindowCompat.getInsetsController(window, view).apply {
isAppearanceLightStatusBars = pageIsLight
isAppearanceLightNavigationBars = pageIsLight
}
}
androidx.compose.runtime.DisposableEffect(Unit) {
onDispose {
(view.context as? Activity)?.window?.let { WindowCompat.getInsetsController(it, view).show(WindowInsetsCompat.Type.systemBars()) }
(view.context as? Activity)?.window?.let { window ->
val controller = WindowCompat.getInsetsController(window, view)
controller.show(WindowInsetsCompat.Type.systemBars())
controller.isAppearanceLightStatusBars = !dark
controller.isAppearanceLightNavigationBars = !dark
}
}
}

Expand Down
Loading