fix: status bar and gesture nav icons follow the reading page, not the app theme - #70
Merged
Merged
Conversation
…e app theme "the status bar and swipe up bar stay white in dark mode reader" The status bar and gesture nav bar are transparent and sit directly over whatever the reader actually draws behind them -- not over ReaderBar's own themed pill, which just went back to following the app's own light/dark setting rather than the reading theme. Their icon appearance (isAppearanceLightStatusBars/isAppearanceLightNavigationBars) was still only ever set once, globally, from the app's own theme in GrimReaderTheme -- so a light appearance (dark icons, meant for a light background) stayed on top of a black reading page or comic page regardless of what the page actually showed. Both readers now set icon appearance from what the page actually shows: EpubReaderScreen from the selected reading theme (light/sepia -> light appearance, dark/black/forest -> dark appearance), PageReaderScreen from its own existing night-mode/CBX-is-always-black logic. Both restore to match the app's own isSystemInDarkTheme() on leaving, same signal EpubReaderScreen already used for its default reading theme. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M421Z8byhEsWKMq7eWWqDN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"the status bar and swipe up bar stay white in dark mode reader"
The status bar and gesture nav bar are transparent and sit directly over
whatever the reader actually draws behind them — not over
ReaderBar'sown themed pill, which just went back to following the app's own
light/dark setting rather than the reading theme. Their icon appearance
(
isAppearanceLightStatusBars/isAppearanceLightNavigationBars) wasstill only ever set once, globally, from the app's own theme in
GrimReaderTheme— so a light appearance (dark icons, meant for a lightbackground) stayed on top of a black reading page or comic page
regardless of what the page actually showed.
Both readers now set icon appearance from what the page actually shows:
EpubReaderScreenfrom the selected reading theme (light/sepia → lightappearance, dark/black/forest → dark appearance),
PageReaderScreenfromits own existing night-mode/CBX-is-always-black logic. Both restore to
match the app's own
isSystemInDarkTheme()on leaving, same signalEpubReaderScreenalready used for its default reading theme.🤖 Generated with Claude Code