Repository navigation
Rollup of 9 pull requests - #164804
Merged
Merged
Rollup of 9 pull requests#164804
Conversation
This updates the rust-toolchain.toml file to nightly-2026-10-08 (1d81eb4).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@5c543b0 New upstream ref: rust-lang/rust@1d81eb4 Filtered ref: rust-lang/rustc_codegen_cranelift@8002d19 Upstream diff: rust-lang/rust@5c543b0...1d81eb4 This merge was created using https://github.com/rust-lang/josh-sync.
Do not suggest
```
help: consider importing this module
|
LL + use a;
|
```
Suggest renamed re-exports:
```
error[E0603]: module `i` is private
--> $DIR/privacy1.rs:172:20
|
LL | use self::foo::i::A;
| ^ private module
|
note: the module `i` is defined here
--> $DIR/privacy1.rs:177:9
|
LL | mod i {
| ^^^^^
help: consider importing this struct through its public re-export instead
|
LL - use self::foo::i::A;
LL + use mytest::foo::Z;
|
```
Suggest renamed imports:
```
error[E0404]: expected trait, found struct `Debug`
--> $DIR/suggest-re-exported-name.rs:7:22
|
LL | pub fn foo() -> impl Debug {
| ^^^^^ not a trait
|
help: consider using this trait through its public re-export instead
|
LL | pub fn foo() -> impl OtherDebug {
| +++++
```
This updates the rust-toolchain.toml file to nightly-2026-10-12 (080cc27).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@1d81eb4 New upstream ref: rust-lang/rust@080cc27 Filtered ref: rust-lang/rustc_codegen_cranelift@75014c2 Upstream diff: rust-lang/rust@1d81eb4...080cc27 This merge was created using https://github.com/rust-lang/josh-sync.
This updates the rust-toolchain.toml file to nightly-2026-10-14 (822182d).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@080cc27 New upstream ref: rust-lang/rust@822182d Filtered ref: rust-lang/rustc_codegen_cranelift@5ce1205 Upstream diff: rust-lang/rust@080cc27...822182d This merge was created using https://github.com/rust-lang/josh-sync.
This updates the rust-toolchain.toml file to nightly-2026-10-19 (b6eeb93).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@822182d New upstream ref: rust-lang/rust@b6eeb93 Filtered ref: rust-lang/rustc_codegen_cranelift@7f82b33 Upstream diff: rust-lang/rust@822182d...b6eeb93 This merge was created using https://github.com/rust-lang/josh-sync.
Update to Cranelift 0.137
records current behaviour. for an anonymous lifetime the suggestion renders use<'_>, which resolves to the first elided lifetime in the signature. two of the cases here still fail after applying it, and one stops resolving entirely and reports a missing lifetime specifier on top of the original error.
for an anonymous lifetime the suggestion rendered use<'_>, which resolves to the first elided lifetime in the signature. with several of them it either captured the wrong one or stopped resolving and reported a missing lifetime specifier on top of the original error. when the hidden type captures more than one anonymous lifetime the suggestion now names them in the signature and lists those names in the bound. a signature with a single elided lifetime keeps the shorter use<'_> form. fixes rust-lang#132199
suggest_name_regions names several regions against one set of used names and adds the new generic parameters once, and suggest_name_region now delegates to it
This updates the rust-toolchain.toml file to nightly-2026-10-23 (7189d39).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@b6eeb93 New upstream ref: rust-lang/rust@7189d39 Filtered ref: rust-lang/rustc_codegen_cranelift@6efc32f Upstream diff: rust-lang/rust@b6eeb93...7189d39 This merge was created using https://github.com/rust-lang/josh-sync.
And "eager (type alias)" with "unchecked (type alias)".
rustbot
added
T-compiler
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
Author
|
Trying commonly failed jobs |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
Rollup of 9 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Oct 23, 2026
This was referenced Oct 23, 2026
Draft
Tweak output on misused
const parameter to provide more context and more accurate suggestion
#164775
Open
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing fe2b43d (parent) -> e481b82 (this PR) Test differencesShow 334 test diffsStage 1
Stage 2
(and 216 additional test diffs) Additionally, 18 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e481b820663a10f5dad2478b2246daf73482ba82 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (e481b82): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.5%, secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.6%, secondary 0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 488.459s -> 487.9s (-0.11%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: fe2b43dd21 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
local_pointer!untilthread_cleanupis run #163799 (std: keep value oflocal_pointer!untilthread_cleanupis run)'_inuse<...>for E0700 #163684 (suggest named lifetimes instead of'_inuse<...>for E0700)use foo as bar;on resolution error suggestions #164167 (Account foruse foo as bar;on resolution error suggestions)checked_type_aliases#164528 (Complete the various renamings of terms belonging to featurechecked_type_aliases)r? @ghost
Create a similar rollup