Repository navigation
Rollup of 9 pull requests - #164805
Closed
JonathanBrouwer wants to merge 42 commits into
Closed
Rollup of 9 pull requests#164805JonathanBrouwer wants to merge 42 commits into
JonathanBrouwer wants to merge 42 commits into
Conversation
This updates the rust-toolchain.toml file to nightly-2026-10-08 (1d81eb4).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@5c543b0 New upstream ref: rust-lang/rust@1d81eb4 Filtered ref: rust-lang/rustc_codegen_cranelift@8002d19 Upstream diff: rust-lang/rust@5c543b0...1d81eb4 This merge was created using https://github.com/rust-lang/josh-sync.
Do not suggest
```
help: consider importing this module
|
LL + use a;
|
```
Suggest renamed re-exports:
```
error[E0603]: module `i` is private
--> $DIR/privacy1.rs:172:20
|
LL | use self::foo::i::A;
| ^ private module
|
note: the module `i` is defined here
--> $DIR/privacy1.rs:177:9
|
LL | mod i {
| ^^^^^
help: consider importing this struct through its public re-export instead
|
LL - use self::foo::i::A;
LL + use mytest::foo::Z;
|
```
Suggest renamed imports:
```
error[E0404]: expected trait, found struct `Debug`
--> $DIR/suggest-re-exported-name.rs:7:22
|
LL | pub fn foo() -> impl Debug {
| ^^^^^ not a trait
|
help: consider using this trait through its public re-export instead
|
LL | pub fn foo() -> impl OtherDebug {
| +++++
```
This updates the rust-toolchain.toml file to nightly-2026-10-12 (080cc27).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@1d81eb4 New upstream ref: rust-lang/rust@080cc27 Filtered ref: rust-lang/rustc_codegen_cranelift@75014c2 Upstream diff: rust-lang/rust@1d81eb4...080cc27 This merge was created using https://github.com/rust-lang/josh-sync.
This updates the rust-toolchain.toml file to nightly-2026-10-14 (822182d).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@080cc27 New upstream ref: rust-lang/rust@822182d Filtered ref: rust-lang/rustc_codegen_cranelift@5ce1205 Upstream diff: rust-lang/rust@080cc27...822182d This merge was created using https://github.com/rust-lang/josh-sync.
This updates the rust-toolchain.toml file to nightly-2026-10-19 (b6eeb93).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@822182d New upstream ref: rust-lang/rust@b6eeb93 Filtered ref: rust-lang/rustc_codegen_cranelift@7f82b33 Upstream diff: rust-lang/rust@822182d...b6eeb93 This merge was created using https://github.com/rust-lang/josh-sync.
Update to Cranelift 0.137
records current behaviour. for an anonymous lifetime the suggestion renders use<'_>, which resolves to the first elided lifetime in the signature. two of the cases here still fail after applying it, and one stops resolving entirely and reports a missing lifetime specifier on top of the original error.
for an anonymous lifetime the suggestion rendered use<'_>, which resolves to the first elided lifetime in the signature. with several of them it either captured the wrong one or stopped resolving and reported a missing lifetime specifier on top of the original error. when the hidden type captures more than one anonymous lifetime the suggestion now names them in the signature and lists those names in the bound. a signature with a single elided lifetime keeps the shorter use<'_> form. fixes rust-lang#132199
suggest_name_regions names several regions against one set of used names and adds the new generic parameters once, and suggest_name_region now delegates to it
This updates the rust-toolchain.toml file to nightly-2026-10-23 (7189d39).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@b6eeb93 New upstream ref: rust-lang/rust@7189d39 Filtered ref: rust-lang/rustc_codegen_cranelift@6efc32f Upstream diff: rust-lang/rust@b6eeb93...7189d39 This merge was created using https://github.com/rust-lang/josh-sync.
And "eager (type alias)" with "unchecked (type alias)".
…bjorn3 rustc_codegen_cranelift subtree update Subtree update of `rustc_codegen_cranelift` to rust-lang/rustc_codegen_cranelift@421bcfe. The main highlight this time is updating Cranelift to 0.137. This fixes an ABI issue on Windows. Created using https://github.com/rust-lang/josh-sync. r? @ghost @rustbot label +A-codegen +A-cranelift +T-compiler +subtree-sync
…=joboet std: keep value of `local_pointer!` until `thread_cleanup` is run ( **NOTE**: LLM **was** used to write the initial version of these ~26 lines of code, subsequently also edited by me during the review (`LocalPointer::__new` now delegates to the new `LocalPointer::__new_with_dtor`; I did hide the `keep_current` inside the initialization block of `CURRENT`). ) The PR fixes a memory leak specific for the ESP-IDF target which happens during thread destruction. The TL;DR is that the current code relies on behavior which is **not** mandated by the POSIX spec, and just happens to work fine on the few major platforms that use that code (bionic, openbsd). More details [in this comment and the ones that follow](esp-rs/esp-idf#522 (comment)). Note also that - **according to the LLM** - `glibc` and `musl` would leak too, **if** they were using pthread keys in the first place. So it is not like ESP-IDF is the outlier here. In fact, the LLM even suggested `#[cfg(all(target_family = "unix", not(target_thread_local)))]` instead of `#[cfg(target_os = "espidf")]`, but let's take small steps. I can't test on those other platforms anyway, as they are relatively exotic (gnux32, open-harmony - basically `glibc` and `musl` targets without Native-TLS support). CC @joboet CC @kyrias
…youxu Bump dist-x86_64-illumos to Ubuntu 22.04 So that it can get new CA certificates.
borrowck dataflow: respect borrow shallowness when killing borrows that conflict with assignments It's not a conflict to write to a sub-place of a shallowly borrowed place, so it's unsound to kill shallow borrows when we encounter assignments to their sub-places. Fixes rust-lang#160599 on the default borrow checker and under `-Zpolonius=next`. I haven't touched `-Zpolonius=legacy` since I'm not sure how much we're maintaining it, but at a glance the fix looks like it would be the same.
…-use-bound, r=oli-obk suggest named lifetimes instead of `'_` in `use<...>` for E0700 when a signature has more than one elided lifetime, the suggested `use<'_>` captures only the first in a case like `fn f(_a: &u8, b: &T) -> impl Sized` it stops resolving entirely and adds `error[E0106]` on top of the original error all at `MachineApplicable`. when the hidden type captures more than one anonymous lifetime the suggestion now names them in the signature and lists those names in the bound which is the desired output from the issue. a signature with a single elided lifetime keeps the shorter `use<'_>`. this reuses the three-part shape `AddPreciseCapturingAndParams` already emits for argument-position `impl Trait` in the same function. note. the argument-position `impl Trait` path in `AddPreciseCapturingAndParams` has the same defect when the signature also has elided reference lifetimes: `fn f(_a: impl Sized, x: &u8, y: &u8) -> impl Sized` still suggests `use<'_, T>` which produces `E0106` plus the original `E0700`. it is `MaybeIncorrect` so rustfix does not apply it but the suggestion misleads. ill follow up on that. the new test is `//@ run-rustfix` with a `.fixed` file that compiles which also let `tests/ui/lifetimes/issue-105227.rs` drop its `FIXME(precise_capturing): Add rustfix here after dealing w/ elided lifetimes`. fixes rust-lang#132199 r? @oli-obk
Account for `use foo as bar;` on resolution error suggestions
Do not suggest
```
help: consider importing this module
|
LL + use a;
|
```
Suggest renamed re-exports:
```
error[E0603]: module `i` is private
--> $DIR/privacy1.rs:172:20
|
LL | use self::foo::i::A;
| ^ private module
|
note: the module `i` is defined here
--> $DIR/privacy1.rs:177:9
|
LL | mod i {
| ^^^^^
help: consider importing this struct through its public re-export instead
|
LL - use self::foo::i::A;
LL + use mytest::foo::Z;
|
```
Suggest renamed imports:
```
error[E0404]: expected trait, found struct `Debug`
--> $DIR/suggest-re-exported-name.rs:7:22
|
LL | pub fn foo() -> impl Debug {
| ^^^^^ not a trait
|
help: consider using this trait through its public re-export instead
|
LL | pub fn foo() -> impl OtherDebug {
| +++++
```
Fix rust-lang#76566.
…-obk Make async drop shim proxy pinned Fixes rust-lang#164433 The async drop shim proxy is missing the pinning transformation, so `drop(_1)` won't be edited in `build_future_drop_poll_shim`, but `_1` would be re-written to `Pin<&mut _>`. Then we would just drop the `Pin` and miss dropping the inner coroutine. r? oli-obk
Complete the various renamings of terms belonging to feature `checked_type_aliases` Various terms used in the context of feature `checked_type_aliases` have undergone renamings. See PRs rust-lang#140249 and rust-lang#158758. However, these PRs didn't update every single occurrence. This PR rectifies that. For context, the renamings are 1. weak (alias (type)) → free (alias (type)) 2. lazy (type alias) → checked (type alias), LTA → CTA 3. eager (type alias) → unchecked (type alias) Moreover, I've renamed `tests/ui/checked-type-alias/` to `tests/ui/checked-type-aliases/` in accordance with the name of the feature, `checked_type_aliases`. <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
miri: fix ICE when caller signature is c-variadic but callee is not It's entirely unnecessary to pass the `extra_args` to the *callee* signature. We only need them on the caller side. This also simplifies c-variadic passing a bit. Fixes rust-lang/miri#5465 r? @oli-obk
rustbot
added
A-CI
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Trying commit 0afcc37 with merge 748f822… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/39977365940 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
Rollup of 9 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
Member
|
This rollup seems to be identical to #164804. |
Member
Author
|
@bors try cancel |
Contributor
|
Try build cancelled. Cancelled workflows: Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
local_pointer!untilthread_cleanupis run #163799 (std: keep value oflocal_pointer!untilthread_cleanupis run)'_inuse<...>for E0700 #163684 (suggest named lifetimes instead of'_inuse<...>for E0700)use foo as bar;on resolution error suggestions #164167 (Account foruse foo as bar;on resolution error suggestions)checked_type_aliases#164528 (Complete the various renamings of terms belonging to featurechecked_type_aliases)r? @ghost
Create a similar rollup