core: Add examples and assembly tests for `abort_immediate` by tgross35 · Pull Request #163575 · rust-lang/rust

tgross35 · 2026-10-01T02:08:29Z

This isn't the most complicated function, but it currently isn't used
anywhere in-tree (typically intrinsics::abort is used instead) and
there are no examples or tests. Copy the examples from abort since
this should behave similarly, and also cover it in an assembly test. We
don't really need the assembly check for any guarantees but it is handy
to reference what the intrinsic actually does, and will let us know if
anything changes.

I also added tests for breakpoint on more platforms since these were
easy to do together.

Tracking issue: #154601

rustbot · 2026-10-01T02:08:34Z

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 21 candidates

tgross35 · 2026-10-01T02:08:42Z

r? libs

tgross35 · 2026-10-01T05:24:36Z

My scratch space for seeing what the various arches do https://rust.godbolt.org/z/Gs9jKPG7x

tgross35 · 2026-10-01T17:38:35Z

@bors try jobs=test-x86_64-gnu-nopt,test-various,test-x86_64-gnu-llvm-22-*

core: Add examples and assembly tests for `abort_immediate` try-job: test-x86_64-gnu-nopt try-job: test-various try-job: test-x86_64-gnu-llvm-22-*

tgross35 · 2026-10-01T18:50:51Z

@bors try jobs=test-x86_64-gnu-nopt,test-various,test-x86_64-gnu-llvm-22-*

core: Add examples and assembly tests for `abort_immediate` try-job: test-x86_64-gnu-nopt try-job: test-various try-job: test-x86_64-gnu-llvm-22-*

rust-bors · 2026-10-01T21:15:05Z

☀️ Try build successful (CI)
Build commit: 37b4513 (37b4513e2f97ccce286b5cd75747efaa239f81a1)
Base parent: 837b18a (837b18aae097503892d7aab6c7ddce332a991a21)

…uwer Rollup of 14 pull requests Successful merges: - #163575 (core: Add examples and assembly tests for `abort_immediate`) - #163664 (Add new `RUSTC_BOOTSTRAP=-allow-unstable-compiler-flags` mode for testing stable compiler behavior in UI tests) - #163104 ([debuginfo] Emit `usize` and `isize` as typedefs) - #163338 (MIR move elimination [4/6]: MoveElimination) - #163701 (add ReadDir::dir to get the directory handle of the underlying directory) - #164488 (Don't try to skip anything in `Skip::advance_by(0)`) - #164578 (Don't ignore unknown LLVM diagnostics) - #164611 (Improve bit permutation codegen) - #164612 (std: Combine `is_powerpc64_feature_detected` into `is_powerpc_feature_detected`) - #162668 (document that `!` does bitwise and logical negation) - #164264 (lint: suggest `fXX::is_nan` for unsuffixed NaN comparisons) - #164509 (layout invariant: turn delayed bug back into proper assertion) - #164594 (rustdoc: Correctly handle inner `deprecated` attribute on modules) - #164629 (arch::breakpoint: avoid confusing 'equivalent' terminology)

JonathanBrouwer · 2026-10-20T12:58:49Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #164632 (comment)

rust-bors · 2026-10-20T12:58:58Z

This pull request was unapproved.

This PR was contained in a rollup (#164632), which was unapproved.

View changes since this unapproval

We can reuse the test setup for other intrinsics, saving a bit of build time and repeated setup.

This isn't the most complicated function, but it currently isn't used anywhere in-tree (typically `intrinsics::abort` is used instead) and there are no examples or tests. Copy the examples from `abort` since this should behave similarly, and also cover it in an assembly test. We don't really need the assembly check for any guarantees but it is handy to reference what the intrinsic actually does, and will let us know if anything changes. I also added tests for `breakpoint` on more platforms since these were easy to do together.

rustbot · 2026-10-20T22:03:58Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

tgross35 · 2026-10-20T22:05:16Z

Intrinsics was renamed, updated. No try since PR CI should cover it

@bors r=JohnTitor

rust-bors · 2026-10-20T22:05:19Z

📌 Commit c40b599 has been tentatively approved by JohnTitor

It will be put into the queue for this repository once PR CI succeeds.

…=JohnTitor core: Add examples and assembly tests for `abort_immediate` This isn't the most complicated function, but it currently isn't used anywhere in-tree (typically `intrinsics::abort` is used instead) and there are no examples or tests. Copy the examples from `abort` since this should behave similarly, and also cover it in an assembly test. We don't really need the assembly check for any guarantees but it is handy to reference what the intrinsic actually does, and will let us know if anything changes. I also added tests for `breakpoint` on more platforms since these were easy to do together. Tracking issue: rust-lang#154601

Rollup of 5 pull requests Successful merges: - #164672 (Bump `rustls-webpki` to 0.103.16 and `webpki-roots` to 1.0.10) - #163575 (core: Add examples and assembly tests for `abort_immediate`) - #163338 (MIR move elimination [4/6]: MoveElimination) - #163180 (Add more documentation for `chroot`, including an example and a manpage link) - #164638 (Make mir-opt blessing work again)

Rollup merge of #163575 - tgross35:abort-immediate-update, r=JohnTitor core: Add examples and assembly tests for `abort_immediate` This isn't the most complicated function, but it currently isn't used anywhere in-tree (typically `intrinsics::abort` is used instead) and there are no examples or tests. Copy the examples from `abort` since this should behave similarly, and also cover it in an assembly test. We don't really need the assembly check for any guarantees but it is handy to reference what the intrinsic actually does, and will let us know if anything changes. I also added tests for `breakpoint` on more platforms since these were easy to do together. Tracking issue: #154601

Rollup of 5 pull requests Successful merges: - rust-lang/rust#164672 (Bump `rustls-webpki` to 0.103.16 and `webpki-roots` to 1.0.10) - rust-lang/rust#163575 (core: Add examples and assembly tests for `abort_immediate`) - rust-lang/rust#163338 (MIR move elimination [4/6]: MoveElimination) - rust-lang/rust#163180 (Add more documentation for `chroot`, including an example and a manpage link) - rust-lang/rust#164638 (Make mir-opt blessing work again)

rustbot assigned JonathanBrouwer Oct 1, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 1, 2026

rustbot assigned JohnTitor and unassigned JonathanBrouwer Oct 1, 2026