Repository navigation
Rollup of 5 pull requests - #164673
Rollup of 5 pull requests#164673
Conversation
We can reuse the test setup for other intrinsics, saving a bit of build time and repeated setup.
This isn't the most complicated function, but it currently isn't used anywhere in-tree (typically `intrinsics::abort` is used instead) and there are no examples or tests. Copy the examples from `abort` since this should behave similarly, and also cover it in an assembly test. We don't really need the assembly check for any guarantees but it is handy to reference what the intrinsic actually does, and will let us know if anything changes. I also added tests for `breakpoint` on more platforms since these were easy to do together.
To mitigate the eMudhra Intermediate CA Compromise.
… r=Kobzol Bump `rustls-webpki` to 0.103.16 and `webpki-roots` to 1.0.10 To mitigate the eMudhra Intermediate CA Compromise. r? @Kobzol
…=JohnTitor core: Add examples and assembly tests for `abort_immediate` This isn't the most complicated function, but it currently isn't used anywhere in-tree (typically `intrinsics::abort` is used instead) and there are no examples or tests. Copy the examples from `abort` since this should behave similarly, and also cover it in an assembly test. We don't really need the assembly check for any guarantees but it is handy to reference what the intrinsic actually does, and will let us know if anything changes. I also added tests for `breakpoint` on more platforms since these were easy to do together. Tracking issue: rust-lang#154601
…ination, r=tmiasko MIR move elimination [4/6]: MoveElimination Depends on rust-lang#163336 and rust-lang#163337 This PR implements the `MoveElimination` pass from rust-lang/rfcs#3943. This pass uses the analysis results from `PreciseLiveness` to unify locals that are related by an assignment. This also includes an alias-fixup pass which is needed because some rvalues don't allow sources to overlap with the destination place. The pass is only enabled under `-Zmir-move-elimination`. This flag also disables `DestinationPropagation`, which is superseded by the new pass. r? tmiasko
Add more documentation for `chroot`, including an example and a manpage link As requested in rust-lang#163067 . This adds an example, adds a manpage link, adds a mention that it requires privileges, and adds an explanation that POSIX doesn't *require* it to be async-signal-safe but it's safe in practice on our targets.
…ianqk Make mir-opt blessing work again Makes `./x test mir-opt --bless` work again. @rustbot label A-testsuite A-mir-opt
|
@bors r+ p=5 force |
This comment has been minimized.
This comment has been minimized.
Rollup of 5 pull requests Successful merges: - #164672 (Bump `rustls-webpki` to 0.103.16 and `webpki-roots` to 1.0.10) - #163575 (core: Add examples and assembly tests for `abort_immediate`) - #163338 (MIR move elimination [4/6]: MoveElimination) - #163180 (Add more documentation for `chroot`, including an example and a manpage link) - #164638 (Make mir-opt blessing work again)
|
💔 Test for 8555fe2 failed: CI. Failed job:
|
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 1731fae (parent) -> 6a58677 (this PR) Test differencesShow 178 test diffsStage 1
Stage 2
Additionally, 115 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6a58677913ae3e443146503de3933abef0b2eda3 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (6a58677): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.0%, secondary -0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.7%, secondary 0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 490.972s -> 488.496s (-0.50%) |
|
📌 Perf builds for each rolled up PR:
parent commit: 1731faea0d In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
View all comments
Successful merges:
rustls-webpkito 0.103.16 andwebpki-rootsto 1.0.10 #164672 (Bumprustls-webpkito 0.103.16 andwebpki-rootsto 1.0.10)abort_immediate#163575 (core: Add examples and assembly tests forabort_immediate)chroot, including an example and a manpage link #163180 (Add more documentation forchroot, including an example and a manpage link)r? @ghost
Create a similar rollup