Skip to content

Rollup of 5 pull requests - #160411

Merged
rust-bors[bot] merged 12 commits into
rust-lang:mainfrom
Zalathar:rollup-GQKNuVR
Aug 3, 2026
Merged

Rollup of 5 pull requests#160411
rust-bors[bot] merged 12 commits into
rust-lang:mainfrom
Zalathar:rollup-GQKNuVR

Conversation

@Zalathar

@Zalathar Zalathar commented Aug 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

ywxt and others added 12 commits July 29, 2026 19:14
Signed-off-by: Seth Rollins <sethryanrollins@gmail.com>
…Amanieu

Add NEON support for is_ascii and eq_ignore_ascii_case

Results on my aarch64 machine.

## 1. `is_ascii`

### 1.1 Raw Data (ns/iter, case00_libcore only — the path that calls `bytes.is_ascii()`)

| Input | Baseline (NEON off) | Optimized (NEON on) | Change |
|---|---|---|---|
| long | 19.69 | 6.46 | **-67.2%** |
| unaligned_both_long | 22.60 | 8.92 | **-60.5%** |
| unaligned_head_long | 20.62 | 8.81 | **-57.3%** |
| unaligned_tail_long | 21.15 | 8.68 | **-59.0%** |
| medium | 3.10 | 2.92 | -5.8% |
| short | 3.77 | 3.81 | +1.1% |
| unaligned_both_medium | 2.59 | 2.83 | +9.3% |
| unaligned_head_medium | 2.95 | 5.00 | +69.5% |
| unaligned_tail_medium | 2.37 | 2.96 | +24.9% |

### 1.2 Grouped Comparison (case00_libcore — the path affected by the change)

| Group | Baseline sum (ns) | Optimized sum (ns) | Change |
|---|---|---|---|
| **LONG (~350B, 4 items)** | 84.06 | 32.87 | **-60.9%** |
| **MEDIUM/SHORT (~16–32B, 5 items)** | 14.78 | 17.52 | +18.5% |
| All 9 items | 98.84 | 50.39 | **-49.0%** |

## 2. `eq_ignore_ascii_case`

### 2.1 Raw Data (ns/iter)

| Bench | Baseline (NEON off) | Optimized (NEON on) | Change |
|---|---|---|---|
| bench_large_str_eq | 6235.89 | 546.61 | **-91.2%** |
| bench_medium_str_eq | 780.81 | 68.05 | **-91.3%** |
| bench_medium_str_tail_mismatch | 786.84 | 65.76 | **-91.6%** |
| bench_str_31_bytes_eq | 35.87 | 3.98 | **-88.9%** |
| bench_str_17_bytes_eq | 19.62 | 4.05 | **-79.4%** |
| bench_medium_str_early_mismatch | 1.32 | 2.42 | +0.75 ns |
| bench_str_of_8_bytes_eq | 9.20 | 9.20 | 0.0% |
| bench_str_under_8_bytes_eq | 3.49 | 3.49 | 0.0% |

### 2.2 Grouped Comparison

| Group | Scenario | Baseline | Optimized | Change |
|---|---|---|---|---|
| **≥16B equal** | 17B / 31B / MEDIUM / LARGE | 19.6–6236 ns | 4.0–547 ns | **-79% ~ -91%** |
| **≥16B tail mismatch** | MEDIUM, last byte differs | 786.84 ns | 65.76 ns | **-91.6%** |
| **≥16B early mismatch** | MEDIUM, first byte differs | 1.32 ns | 2.42 ns | +0.75 ns |
| **<16B** | 8B / <8B equal | 3.49–9.20 ns | 3.49–9.20 ns | no change |

r? @Amanieu
bootstrap: Don't pass `Kind` to some places that don't need it

The current CLI step's `Kind` was being passed deep into some selector-matching code that doesn't seem to actually need it. It seems that the kind associated with a step's `ShouldRun` paths/aliases always comes from that step, so proceeding to compare it against the step's kind later can never fail and doesn't achieve anything.

As far as I can tell, this is a relic of rust-lang#91965 that (due to subsequent changes) doesn't do anything useful and also doesn't make a lot of conceptual sense.

This PR therefore removes the `Kind` parameter from `PathSet::check`, and removes the `Kind` field from `TaskPath`.

Touching `TaskPath` causes a lot of churn in snapshot tests, but there don't seem to be any changes in actual behaviour.
rustc_data_structures: Cleanup jobserver initialization

In the past the initialization was more complicated, with two stages for "unchecked" and "checked" `jobserver::Client`.
Now everything can just be merged into a single function.
…/check_eii_impl, r=jieyouxu

Remove redundant target check from check_eii_impl

Part of rust-lang#131229 which is the parent issue of rust-lang#153101
…ns, r=jieyouxu

Update GitHub Actions to v7.0.1

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://redirect.github.com/actions/checkout) | action | patch | `v7.0.0` → `v7.0.1` |
| [actions/upload-artifact](https://redirect.github.com/actions/upload-artifact) | action | patch | `v7` → `v7.0.1` |

---

### Release Notes

<details>
<summary>actions/checkout (actions/checkout)</summary>

### [`v7.0.1`](https://redirect.github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v701)

[Compare Source](https://redirect.github.com/actions/checkout/compare/v7.0.0...v7.0.1)

- Bump github/codeql-action from 3 to 4 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in [#&rust-lang#8203;2475](https://redirect.github.com/actions/checkout/pull/2475)
- Bump actions/setup-node from 4 to 6 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in [#&rust-lang#8203;2477](https://redirect.github.com/actions/checkout/pull/2477)
- Bump docker/build-push-action from 6.5.0 to 7.2.0 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in [#&rust-lang#8203;2478](https://redirect.github.com/actions/checkout/pull/2478)
- Bump docker/login-action from 3.3.0 to 4.2.0 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in [#&rust-lang#8203;2479](https://redirect.github.com/actions/checkout/pull/2479)
- Bump actions/checkout from 6 to 7 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in [#&rust-lang#8203;2488](https://redirect.github.com/actions/checkout/pull/2488)
- Bump actions/upload-artifact from 4 to 7 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in [#&rust-lang#8203;2476](https://redirect.github.com/actions/checkout/pull/2476)
- eslint 9 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in [#&rust-lang#8203;2474](https://redirect.github.com/actions/checkout/pull/2474)
- Bump the minor-actions-dependencies group with 2 updates by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot)\[bot] in [#&rust-lang#8203;2499](https://redirect.github.com/actions/checkout/pull/2499)
- skip running unsafe pr check if input is default by [@&rust-lang#8203;aiqiaoy](https://redirect.github.com/aiqiaoy) in [#&rust-lang#8203;2518](https://redirect.github.com/actions/checkout/pull/2518)
- trim only ascii whitespace for branch by [@&rust-lang#8203;aiqiaoy](https://redirect.github.com/aiqiaoy) in [#&rust-lang#8203;2521](https://redirect.github.com/actions/checkout/pull/2521)
- escape values passed to --unset by [@&rust-lang#8203;aiqiaoy](https://redirect.github.com/aiqiaoy) in [#&rust-lang#8203;2530](https://redirect.github.com/actions/checkout/pull/2530)

</details>

<details>
<summary>actions/upload-artifact (actions/upload-artifact)</summary>

### [`v7.0.1`](https://redirect.github.com/actions/upload-artifact/releases/tag/v7.0.1)

[Compare Source](https://redirect.github.com/actions/upload-artifact/compare/v7...v7.0.1)

#### What's Changed

- Update the readme with direct upload details by [@&rust-lang#8203;danwkennedy](https://redirect.github.com/danwkennedy) in [#&rust-lang#8203;795](https://redirect.github.com/actions/upload-artifact/pull/795)
- Readme: bump all the example versions to v7 by [@&rust-lang#8203;danwkennedy](https://redirect.github.com/danwkennedy) in [#&rust-lang#8203;796](https://redirect.github.com/actions/upload-artifact/pull/796)
- Include changes in typespec/ts-http-runtime 0.3.5 by [@&rust-lang#8203;yacaovsnc](https://redirect.github.com/yacaovsnc) in [#&rust-lang#8203;797](https://redirect.github.com/actions/upload-artifact/pull/797)

**Full Changelog**: <actions/upload-artifact@v7...v7.0.1>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - Between 12:00 AM and 03:59 AM, only on Monday (`* 0-3 * * 1`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/rust-lang/rust).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4zLjIiLCJ1cGRhdGVkSW5WZXIiOiI0NC4zLjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Aug 3, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 3, 2026
@Zalathar

Zalathar commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

Rollup of everything.

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 00a7cc2 has been approved by Zalathar

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2026
@rust-bors

rust-bors Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: Zalathar
Duration: 3h 8m 28s
Pushing 65dd30f to main...

@rust-bors
rust-bors Bot merged commit 65dd30f into rust-lang:main Aug 3, 2026
14 checks passed
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#160143 Add NEON support for is_ascii and eq_ignore_ascii_case fc98e0891c6e35f82f1611b9a83b94c6fa9a3819 (link)
#160191 bootstrap: Don't pass Kind to some places that don't need… 06c9b1e50d016cb5772d5f07f994abe5df121bc1 (link)
#160386 rustc_data_structures: Cleanup jobserver initialization 028fa846ac94a373e373c031e1e79db9d47c459f (link)
#160409 Remove redundant target check from check_eii_impl 5922cfd616447d130644e44b4af9d333ce6e80d7 (link)
#160410 Update GitHub Actions to v7.0.1 b5d95900014625bddae30f53b75567199f5b2b63 (link)

previous master: 22057b88b0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 22057b8 (parent) -> 65dd30f (this PR)

Test differences

Show 24 test diffs

Stage 1

  • str::eq_ignore_ascii_case::bench_medium_str_early_mismatch: [missing] -> pass (J1)
  • str::eq_ignore_ascii_case::bench_medium_str_tail_mismatch: [missing] -> pass (J1)

Stage 2

  • str::eq_ignore_ascii_case::bench_medium_str_early_mismatch: [missing] -> pass (J0)
  • str::eq_ignore_ascii_case::bench_medium_str_tail_mismatch: [missing] -> pass (J0)

Additionally, 20 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 65dd30fb9e882a7e8f0be10caca62936db2a98b8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-msvc-ext2: 1h 57m -> 1h 15m (-35.7%)
  2. armhf-gnu: 1h 33m -> 1h 3m (-32.8%)
  3. x86_64-gnu-llvm-22-1: 56m 49s -> 1h 15m (+32.5%)
  4. x86_64-gnu-gcc: 1h 11m -> 48m 45s (-31.9%)
  5. dist-x86_64-solaris: 1h 42m -> 1h 12m (-29.8%)
  6. dist-x86_64-apple: 1h 37m -> 2h 5m (+29.1%)
  7. dist-i586-gnu-i586-i686-musl: 18m 45s -> 23m 24s (+24.8%)
  8. dist-i686-linux: 1h 52m -> 1h 25m (-23.8%)
  9. dist-riscv64-linux-gnu: 1h 31m -> 1h 10m (-23.4%)
  10. dist-apple-various: 2h 1m -> 1h 34m (-22.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (65dd30f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.3% [-6.0%, -1.0%] 4
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.3% [-6.0%, -1.0%] 4

Cycles

Results (primary -0.3%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.9% [0.5%, 1.6%] 3
Regressions ❌
(secondary)
3.0% [0.4%, 8.9%] 5
Improvements ✅
(primary)
-1.1% [-2.1%, -0.5%] 5
Improvements ✅
(secondary)
-1.5% [-4.0%, -0.5%] 9
All ❌✅ (primary) -0.3% [-2.1%, 1.6%] 8

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.286s -> 491.898s (0.33%)
Artifact size: 390.24 MiB -> 391.08 MiB (0.22%)

@Zalathar
Zalathar deleted the rollup-GQKNuVR branch August 3, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants