Split SpannedTypeVisitor into its own crate, rustc_ty_walk - #160362
Split SpannedTypeVisitor into its own crate, rustc_ty_walk#160362joshtriplett wants to merge 2 commits into
SpannedTypeVisitor into its own crate, rustc_ty_walk#160362Conversation
`rustc_privacy` pulls in all of `rustc_ty_utils`, but only wants `SpannedTypeVisitor` and `walk_types`. Move those to a small `rustc_ty_walk` crate. This allows `rustc_privacy` to start building much sooner.
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
|
You need to bless bootstrap, see https://github.com/rust-lang/rust/blob/main/src/bootstrap/README.md#testing |
|
@rustbot ready |
|
I think we should consider splitting up crate A: Queries that need |
|
@mejrs That sounds reasonable. But also, I'm a big fan of incremental steps; we can always split/merge crates further after this. :) |
Yes! Please keep this PR small, I'm not suggesting it is done right here and now (hence, just "considering" 🙂). |
|
☔ The latest upstream changes (presumably #160411) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
rustc_privacypulls in all ofrustc_ty_utils, but only wantsSpannedTypeVisitorandwalk_types. Move those to a smallrustc_ty_walkcrate.This allows
rustc_privacyto start building much sooner.