Internalize format and error-response defaults behind Grape::Util::InheritableSetting accessors#2805
Open
ericproulx wants to merge 1 commit into
Open
Internalize format and error-response defaults behind Grape::Util::InheritableSetting accessors#2805ericproulx wants to merge 1 commit into
ericproulx wants to merge 1 commit into
Conversation
…heritableSetting accessors Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Danger ReportNo issues found. |
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts the
namespace_inheritablehalf of theInheritableSettingcleanup (#2795–#2804 covered the stackable side): the serialization and error-response defaults written by theformat,default_format,default_error_formatteranddefault_error_statusDSL methods are now recorded and read through intention-revealing accessors onGrape::Util::InheritableSetting.New accessors on
InheritableSettingformat/format=namespace_inheritable[:format]default_format/default_format=namespace_inheritable[:default_format]default_error_formatter/default_error_formatter=namespace_inheritable[:default_error_formatter]default_error_status/default_error_status=namespace_inheritable[:default_error_status]Notes:
=rather than theadd_*naming reserved for stackable registrations. The naming now documents the semantics.DSL::RequestResponse(all four get-or-set DSL methods),Endpoint(initialize'sdefault_error_status ||= 500seeding,build_stack,error_middleware_options) andDSL::InsideRoute#error!. With this,error_middleware_optionsno longer touches any raw store.to_hashoutput and any external readers see the same values; the raw keys should now be considered internal.🤖 Generated with Claude Code