Internalize build_params_with and auth behind Grape::Util::InheritableSetting accessors#2808
Open
ericproulx wants to merge 1 commit into
Open
Internalize build_params_with and auth behind Grape::Util::InheritableSetting accessors#2808ericproulx wants to merge 1 commit into
ericproulx wants to merge 1 commit into
Conversation
…eSetting accessors Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Danger ReportNo issues found. |
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth and final per-key batch of the
namespace_inheritablecleanup (after #2805/#2806/#2807): the params-builder strategy written bybuild_withand the authentication configuration written by theauthDSL are now recorded and read through intention-revealing accessors onGrape::Util::InheritableSetting.New accessors on
InheritableSettingbuild_params_with/build_params_with=namespace_inheritable[:build_params_with]auth/auth=namespace_inheritable[:auth]Notes:
build_params_withhas two DSL writers — the API-levelDSL::Routing#build_withand the params-blockDSL::Parameters#build_with— both now funnel through the one accessor, which documents that fact.Middleware::Auth::DSL#auth(get-or-set plus the immediate read feedinguse Grape::Middleware::Auth::Base), andEndpoint(compile!'s@build_params_withsnapshot andwarn_unauthenticated_mounted_app's auth presence check).InheritableSettingindexes intonamespace_inheritableper key anymore — the remaining raw uses are the two bulkto_hashconsumers (Endpoint#prepare_default_path_settings,Instance#to_route_configs), which get dedicated accessors in the upcoming visibility-narrowing PR.🤖 Generated with Claude Code