Internalize contract key maps behind Grape::Util::InheritableSetting accessors#2804
Open
ericproulx wants to merge 1 commit into
Open
Internalize contract key maps behind Grape::Util::InheritableSetting accessors#2804ericproulx wants to merge 1 commit into
ericproulx wants to merge 1 commit into
Conversation
…accessors Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Danger ReportNo issues found. |
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues (and completes the key-conversion phase of) the
InheritableSettingcleanup from #2795–#2803: the Dry::Schema key maps registered bycontractblocks are now recorded and read through intention-revealing accessors onGrape::Util::InheritableSetting.New accessors on
InheritableSettingcontract_key_maps/add_contract_key_map(key_map)namespace_stackable[:contract_key_map]Notes:
Validations::ContractScope(write) andDSL::Declared#declared(read, feedingDeclaredParamsHandler). Thenamespace_stackable[:validations]write inContractScopeis left as is — Internalize params state behind Grape::Util::InheritableSetting accessors #2797 converts it.to_hashoutput and any external readers see the same values; the raw key should now be considered internal.InheritableSettingindexes intonamespace_stackablefor any semantic key anymore, clearing the way for a follow-up that narrows the visibility ofnamespace_stackable/namespace_stackable_with_hash.🤖 Generated with Claude Code