fix(perception_2nodes): fix duplicate node names and TimeSynchronizer race in FPGA streamlined pipeline - #33
Open
prtmxio wants to merge 1 commit into
Conversation
… race in FPGA streamlined pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #19.
When launching
trace_rectify_resize_fpga_streamlined.launch.py, thename=parameter on theNode()action injects a global--ros-args -r __node:=<name>into the process. Since bothRectifyNodeFPGAStreamlinedandResizeNodeFPGAStreamlinedrun inthe same executable and share the same global args, both nodes end up registering with the same ROS name. This triggers the
Publisher already registeredwarning and breakscamera_infodelivery — one node'sTimeSynchronizerstarves, resulting inonly a handful of synced frames over several minutes.
Even after removing
name=(as suggested in the comments), sync was still unreliable. The reason:MultiThreadedExecutorcancall the
imageandcamera_infocallbacks of the same node'smessage_filters::TimeSynchronizerfrom two threadssimultaneously.
TimeSynchronizeris not thread-safe, so messages get silently dropped. The CPU reference(
rectify_resize_node.cpp) always usedSingleThreadedExecutor— this wasn't accidental.Changes
name=from bothtrace_rectify_resize_fpga_streamlinedlaunch files (non-XRT and XRT)rclcpp::NodeOptions()per node instead of a shared instanceMultiThreadedExecutor→SingleThreadedExecutorin both executables