Repository navigation
feat(render): --extremes writes each animation's two farthest poses and their diffs - #1633
Merged
Merged
Conversation
…nd their diffs An agent that cannot see a rig reports seams as numbers, and the numbers miss what one look at a motion's extremes shows. A line baked into a moving part reads as ghost cells in a seam count. In a diff of the motion's two extreme poses it is an obvious moving stroke. `render --extremes` writes three things into each animation set: - `extremes.json`: for every animated channel (bone rotate, translate, scale, shear, held components included; deform offsets; slider mapped time where actually applied), the frame of its minimum and of its maximum on the set's own grid. Separately, it records the geometry pair: the two frames whose corresponding original attachment vertices lie farthest apart, with that distance in world units. The method and the tie rule are written into the file. - `extremes.png`: setup | min | max | |max−min| | |min−setup| | |max−setup|, at the render's own scale. Each diff is the max channel difference of premultiplied RGBA, drawn as luminance on black with no amplification, and a legend row is included. - one `EXTREMES` line per set. It is a reading, not a gate: the exit status never moves. A still set, or a set whose attachment source switches so that no vertex correspondence exists, is a named SKIP for the geometry pair, and its valid channel extrema are still reported. On the gallery the core and spine posers give identical sheets (10 sheets, 344 frame pairs). Ordinary renders are byte-identical with and without the change: 7 recipes, 407 files. The tracked render-hash base is unchanged. Measured: a planted line baked into a moving part shows 10 nonzero pixels in the |max−min| ROI; the same fixture without the plant shows 0. Two runs give byte-identical JSON and PNG. Full selftest and smoke pass. Rejected: - choosing the pair by a single channel: arbitrary; - clipped-triangle correspondence and same-name source aliasing: guessed identities; - downscaling or amplifying the diff; - making it a gate. Closes #1632 Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1632.
rigc render … --extremeswritesextremes.json,extremes.pngand oneEXTREMESline per animation set. Together they show the motion's two farthest poses and the diffs between them and the setup pose, so an agent can look at a picture before a person does. It is a reading: the exit status never moves.bun run typecheck,bun run lintbun run selftestbun run smokeContradicted in the issue:
Rejected:
🤖 Generated with Claude Code