Repository navigation
feat(editor-roundtrip): name the editor's added convex flag on a concave clip instead of leaving it as unexplained drift - #1631
Merged
Conversation
…ave clip instead of leaving it as unexplained drift #1603 measured that the Spine editor (4.3.26) adds `convex: true` to a concave clipping attachment on export, and that the flag alone accounts for the whole render difference #1585 saw — the runtime then clips with the polygon's convex hull. rigc keeps the authored concave clip, so the round trip now says so in words. After a validated export, for every clipping attachment whose export carries `convex: true` while the build's does not, the tool poses the BUILD's authored setup polygon under the matching skin (weights through `computeWorldVertices`, setup bones, no animation deform) and, if it has a reflex vertex, prints FAIL EDITOR_ADDED_CONVEX_ON_CONCAVE_CLIP skin … slot … attachment … end …: export convex=true, build convex is not true; setup reflex vertices=N; the editor's export clips with the convex hull of the authored concave polygon beside the unchanged per-skin check figures, and the run's verdict counts it. A convex clip, a flag the build itself states, a convex setup that an animation deforms concave, and the same key in another skin are not flagged. `src/render.ts` gains one helper, `setupClipPolygon`, so the tool reaches the runtime through the existing supplier rather than a new link; nothing the compiler emits changes. Measured: red first with the tool unchanged (ERT90, ERT93, ERT95 fail for the missing line; ERT91, 92, 94, 96 pass); green after, with ERT86 and every existing editor control unchanged. On the saved #1585 export the line appears once — skin default, slot clip, end pupil, 37 reflex vertices — and the check JSON is identical apart from job paths. Full selftest 2,695 PASS / 0 FAIL, install smoke 22/22 (remote pool, corpus fetched first). Closes #1630 Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
HQ: merging on green without the AI review — requested at open, not back after 30 minutes (30-minute rule). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1630. The editor round trip names
EDITOR_ADDED_CONVEX_ON_CONCAVE_CLIPwhen the export addsconvex: trueto a clip whose authored setup polygon is concave (posed under its skin), next to the unchanged check figures. On the saved #1585 export: one line, 37 reflex vertices. Red first on three controls with the tool unchanged; full selftest 2,695/0 and smoke 22/22 on the pool. One helper insrc/render.ts; nothing emitted changes.🤖 Generated with Claude Code