Skip to content

move to rescript v13 and use %component_identity #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tsnobip wants to merge 1 commit into
base: master
Choose a base branch
from
+65 −70
Draft

move to rescript v13 and use %component_identity #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

| @rescript/react | ReScript | ReactJS | Documentation |
| --------------- | ---------------------------------- | ------- | ----------------------------------------------------------------- |
| 0.16.x | 13.0+ | 19 |
| 0.15.x | 12.0+ | 19 | |
| 0.14.x | 11.0+ (JSX4 + uncurried mode only) | 19 | |
| 0.12.x, 0.13.x | 11.0+ | 18 | [Link](https://rescript-lang.org/docs/react/latest/introduction) |
Expand Down
126 changes: 60 additions & 66 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rescript/react",
"version": "0.15.0",
"version": "0.16.0",
"description": "React bindings for ReScript",
"files": [
"README.md",
Expand Down Expand Up @@ -31,10 +31,10 @@
"devDependencies": {
"react": "^19.2.0",
"react-dom": "^19.2.0",
"rescript": "^12.0.0"
"rescript": "^13.0.0-alpha.4"

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bump ReScript past the component primitive

With this dependency range, a clean install uses the locked rescript@13.0.0-alpha.4, but src/React.res now depends on the new %component_identity primitive. That primitive is part of the later abstract-Jsx.component compiler change, so this package will fail to compile from a clean checkout before tests run; please depend on a compiler version that contains the primitive or keep using %identity until then.

Useful? React with 👍 / 👎.

},
"peerDependencies": {
"@rescript/runtime": ">=12.0.0",
"@rescript/runtime": ">=13.0.0-alpha.4",
"react": ">=19.2.0",
"react-dom": ">=19.2.0"
}
Expand Down
2 changes: 1 addition & 1 deletion src/React.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type componentLike<'props, 'return> = Jsx.componentLike<'props, 'return>

type component<'props> = Jsx.component<'props>

external component: componentLike<'props, element> => component<'props> = "%identity"
external component: componentLike<'props, element> => component<'props> = "%component_identity"

@module("react")
external createElement: (component<'props>, 'props) => element = "createElement"
Expand Down
Loading