move to rescript v13 and use %component_identity#159
Conversation
tsnobip
force-pushed
the
component-identity
branch
from
ec9aafa to
0a5619d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec9aafa679
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "react": "^19.2.0", | ||
| "react-dom": "^19.2.0", | ||
| "rescript": "^12.0.0" | ||
| "rescript": "^13.0.0-alpha.4" |
There was a problem hiding this comment.
With this dependency range, a clean install uses the locked rescript@13.0.0-alpha.4, but src/React.res now depends on the new %component_identity primitive. That primitive is part of the later abstract-Jsx.component compiler change, so this package will fail to compile from a clean checkout before tests run; please depend on a compiler version that contains the primitive or keep using %identity until then.
Useful? React with 👍 / 👎.
1 participant
UPDATE: we need to wait for the release of v13-alpha.5 to have
%component_identity