Make react/featureflags private (#58744) - #58744
Closed
j-piasecki wants to merge 3 commits into
Closed
j-piasecki wants to merge 3 commits into
j-piasecki wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122353979. |
added 2 commits
September 30, 2026 00:38
Summary: Adds a `dangerouslyExposeInPublicCppHeaders` option to the feature flags config. Flags that opt in are generated into `ReactNativePublicFeatureFlags.h`, whose getters forward to `ReactNativeFeatureFlags` from a generated `.cpp`, so exported headers can read them without including the rest of the module. Opts in the flags that exported headers currently read inline. Changelog: [Internal] Differential Revision: D122353811
Summary: Exported headers that read feature flags inline now go through the generated `ReactNativePublicFeatureFlags.h` instead of `ReactNativeFeatureFlags.h`. Sources that relied on the transitive include now include `ReactNativeFeatureFlags.h` directly. Changelog: [Internal] Differential Revision: D122353873
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 30, 2026
Summary: Pull Request resolved: react#58744 Moves `react/featureflags` from the public tier of the C++ stable API to the private tier. The `<React/FeatureFlags.h>` umbrella and its build plumbing are removed, and the headers include `PrivateGuard.h` instead of `UmbrellaGuard.h`. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D122353979
j-piasecki
force-pushed
the
export-D122353979
branch
from
September 30, 2026 08:06
d624e6e to
f2c3a42
Compare
meta-codesync
Bot
changed the title
react/featureflags privatereact/featureflags private (#58744)
Summary: Pull Request resolved: react#58744 Moves `react/featureflags` from the public tier of the C++ stable API to the private tier. The `<React/FeatureFlags.h>` umbrella and its build plumbing are removed, and the headers include `PrivateGuard.h` instead of `UmbrellaGuard.h`. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D122353979
j-piasecki
force-pushed
the
export-D122353979
branch
from
September 30, 2026 08:11
f2c3a42 to
57e5e59
Compare
|
This pull request has been merged in 0ac7a16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Moves
react/featureflagsfrom the public tier of the C++ stable API to the private tier. The<React/FeatureFlags.h>umbrella and its build plumbing are removed, and the headers includePrivateGuard.hinstead ofUmbrellaGuard.h.Changelog: [Internal]
Reviewed By: rubennorte
Differential Revision: D122353979