Make react/featureflags private (#58744)

Summary:
Pull Request resolved: #58744

Moves `react/featureflags` from the public tier of the C++ stable API to the private tier. The `<React/FeatureFlags.h>` umbrella and its build plumbing are removed, and the headers include `PrivateGuard.h` instead of `UmbrellaGuard.h`.

Changelog: [Internal]

Reviewed By: rubennorte

Differential Revision: D122353979

Author: j-piasecki

packages/react-native/ReactAndroid/build.gradle.kts

@@ -115,7 +115,6 @@ val preparePrefab by
                       Pair("../ReactCommon/cxxreact/React/", "React/"),
                       // react_featureflags
                       Pair("../ReactCommon/react/featureflags/", "react/featureflags/"),
-                      Pair("../ReactCommon/react/featureflags/React/", "React/"),
                       // react_devtoolsruntimesettings
                       Pair(
                           "../ReactCommon/react/devtoolsruntimesettings/",

packages/react-native/ReactCommon/react/featureflags/CMakeLists.txt

@@ -12,7 +12,6 @@ file(GLOB react_featureflags_SRC CONFIGURE_DEPENDS *.cpp)
 add_library(react_featureflags OBJECT ${react_featureflags_SRC})
 
 target_include_directories(react_featureflags PUBLIC ${REACT_COMMON_DIR})
-target_include_directories(react_featureflags INTERFACE ${REACT_COMMON_DIR}/react/featureflags)
 
 target_link_libraries(react_featureflags folly_runtime react_cxxstableapi)
 target_compile_reactnative_options(react_featureflags PRIVATE)

packages/react-native/ReactCommon/react/featureflags/React-featureflags.podspec

@@ -43,11 +43,5 @@ Pod::Spec.new do |s|
   add_rn_third_party_dependencies(s)
   add_rncore_dependency(s)
 
-  s.subspec "featureflagsUmbrella" do |ss|
-    ss.source_files        = "React/*.h"
-    ss.header_dir          = ""
-    ss.header_mappings_dir = "."
-  end
-
   mark_as_react_native_build(s)
 end

packages/react-native/ReactCommon/react/featureflags/React/FeatureFlags.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<03873d0e7381921dc1ed1372eec991c0>>
+ * @generated SignedSource<<4c93a39dd2a8ee5ba24f3f8bc99ac1ae>>
  */
 
 /**
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <react/featureflags/ReactNativeFeatureFlagsAccessor.h>
 #include <react/featureflags/ReactNativeFeatureFlagsProvider.h>

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<bd4f6cafcd3c1bd4217792d0cf25dbe5>>
+ * @generated SignedSource<<3e557788d6bd43975af8dcb392beef94>>
  */
 
 /**
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <react/featureflags/ReactNativeFeatureFlagsProvider.h>
 #include <array>

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsAccessor.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<f09ab21f8e13dddf1b548cb8e156837e>>
+ * @generated SignedSource<<07754aa6f05f6219f95a7b9a2e83ba49>>
  */
 
 /**
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <react/featureflags/ReactNativeFeatureFlagsProvider.h>
 

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<ae3d44a13f9aa325303d58a5f50aac51>>
+ * @generated SignedSource<<feee721a90dc8eb3371e87778bdbccc7>>
  */
 
 /**
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <folly/dynamic.h>
 #include <react/featureflags/ReactNativeFeatureFlagsDefaults.h>

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDynamicProvider.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<c26b8f81fcc99469d0535a89bac18280>>
+ * @generated SignedSource<<94c1abd04adec2f81634da6786979552>>
  */
 
 /**
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h>
 

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSCanary.h

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<ed015255bfc4c47dfb63b99bc8146b78>>
+ * @generated SignedSource<<03cfd37618eb47d4612a78af04c9332f>>
  */
 
 /**
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <react/featureflags/ReactNativeFeatureFlagsOverridesOSSCanary.h>