Skip to content

Drop the "this repo has released none" comments #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 2 commits into from
Aug 27, 2026
Merged

Drop the "this repo has released none" comments #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb47e30
Drop the "this repo has released none" comments
Aug 27, 2026
0d212ae
Merge main into the stale-comment deletion
Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,6 @@ Three separate steps, in this order. Nothing automatic ever broadcasts.
partial run is fixed by running it again rather than by unpicking anything.
2. **Verify.** `RegistryDeployVerifyTest` passes only once every **released**
suite is live on every supported network, with the code that release froze.
This repo has released none, so today it has nothing to check and passes; it
gets a subject the moment step 3 freezes one, and is red from then until step
1 has been run everywhere. That is the order these steps are in.
3. **Tag.** Push a `sol-v*` tag, the sole release trigger. It verifies and
publishes but never broadcasts, which is exactly why step 1 cannot be folded
into it. The release mechanics are `rainix-tag-release`'s.
Expand Down
6 changes: 0 additions & 6 deletions script/Deploy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,4 @@ import {RegistryDeploySuites} from "../src/abstract/RegistryDeploySuites.sol";
/// skips any network that already has code there, so a partial run — five
/// chains of seven, one RPC down — is fixed by running it again rather than by
/// unpicking anything.
///
/// `RegistryDeployVerifyTest` is what says whether this has been run and worked
/// — but only for RELEASED suites, and this repo has released none, so today it
/// has nothing to check and passes. It gets a subject once a release is frozen,
/// and then fails until every supported network has that release's code, which
/// is why the deploy comes before the tag rather than after it.
contract Deploy is RegistryDeploySuites, RainDeployBroadcast {}
Loading