Drop the "this repo has released none" comments - #154
Conversation
Both said the chain group has no subject and passes vacuously. It has one: `src/generated/0_1_7/` is frozen and the released libs declare `address-registry@0_1_7` and `migration-registry@0_1_7`. Correcting them to name 0_1_7 re-arms the same trap, since the next release falsifies it again and nothing expires a comment. Whether `releasedSuites()` is empty is a fact about a return value, readable at that function; what `RegistryDeployChainTest` covers belongs in its own doc rather than restated at the call site. The README keeps the durable half of step 2 — the chain test passes only once every released suite is live on every supported network, with the code that release froze — and the ordering rationale it needs is already in step 3. Closes #153 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe change removes obsolete release verification explanations from Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR removes stale documentation without changing repository behavior or release machinery, so no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
#155 renamed RegistryDeployChainTest to RegistryDeployVerifyTest inside the paragraph this branch deletes, so main re-added it in updated form still carrying the false claim. The deletion stands. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 participant
script/Deploy.solandREADME.mdstep 2 both said this repo has releasednothing, so
RegistryDeployChainTesthas no subject and passes vacuously.It has a subject.
src/generated/0_1_7/{AddressRegistry,MigrationRegistry}.solis frozen on main,
LibAddressRegistryReleaseddeclaresaddress-registry@0_1_7andLibMigrationRegistryReleaseddeclaresmigration-registry@0_1_7, soreleasedSuites()returns two suites and thechain group forks every supported network against them. A reader is told the
test is inert when it is the opposite.
Deleted rather than corrected, per the ruling on #153. Naming 0_1_7 re-arms the
same trap: the next release falsifies it again and nothing expires a comment.
Deletion removes the class instead of resetting the clock.
script/Deploy.sol— the whole trailing paragraph. WhetherreleasedSuites()is empty is a fact about a return value, readable at that function; what
RegistryDeployChainTestcovers belongs in its own doc, not restated here.The "deploy before tag" ordering it ended on is already stated earlier in the
same comment ("something has to put it on chain first, and a
sol-v*tag isnot it ... before tagging").
README.md— the three transient lines of step 2 only. The durable firstsentence stays: the chain test passes only once every released suite is live
on every supported network, with the code that release froze. Step 3 already
carries the ordering rationale ("which is exactly why step 1 cannot be folded
into it").
No replacement prose. Items 2 and 3 of #153 are sibling repos, with their own
issues and PRs: rainlanguage/rain.math.float.deploy#14 and
rainlanguage/rain.factory.deploy#28.
QA
git diff: every removed line is a///line or a README list line, and no non-comment byte changes.src/generated/0_1_7/AddressRegistry.solandsrc/generated/0_1_7/MigrationRegistry.solexist on main, andsrc/lib/LibAddressRegistryReleased.sol/src/lib/LibMigrationRegistryReleased.solemitsuite: "address-registry@0_1_7"andsuite: "migration-registry@0_1_7"intoreleasedSuites(). That is what makes the deleted sentences false, and it is read from the frozen record and the generated libs rather than from any prose.script/Deploy.sol,README.md) and closes it as the machinery owner. Items 2 and 3 are in sibling repos and are covered by DecimalFloatDeployChainTest's comment claims this repo has cut no release, but 0_1_1 is frozen rain.math.float.deploy#14 and script/Build.sol enumerates frozen 0_1_3/0_1_4/0_1_5 snapshots the tree does not hold rain.factory.deploy#28. Also checked the rest of this repo for the same claim: the other "has released nothing" hits (RainDeployVerifyChainEmpty.t.sol,RainDeployVerifySnapshotBase.sol,LibRainDeploySnapshot.soland their tests) are statements about the machinery's behaviour for any repo in that state, not claims about this repo, and are still true - left alone.Closes #153
Summary by CodeRabbit