Repository navigation
Isolate Sparkle smoke launch reports per run - #2218
Merged
Merged
Conversation
Each sparkle-update-smoke run now writes its launch report, app log and isolated home under <output>/runs/<runID>/<state>, so two overlapping runs on the same output can no longer delete or consume each other's report. Adds a test with two runs sharing one output. Fixes #2157
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two overlapping
sparkle-update-smokeruns on the same--outputshared<output>/<state>/launch-ui-smoke.json. One run could delete the other's report before it was read, or pick up the other's report as its own evidence.What changed
runScenarionow takes the run'srunID(already a UUID per run) and puts each scenario'slaunch-ui-smoke.json,app.logand isolated home under<output>/runs/<runID>/<state>/. Overlapping runs no longer share any of those files.testConcurrentRunsKeepSeparateLaunchReports: two runIDs on one output, run A passes, run B (a failing fake app) fails, the report paths differ, and run A's report still exists afterwards.Tools/TranscriptedQA/AGENTS.mdnotes the new layout.Still shared at the output root on purpose:
fake-appcast.xml(evidence only, not read by the scenarios, atomic write) and the summarysparkle-update-smoke.json(atomic write, carries itsrunID, last run wins). Old per-run folders are kept as evidence and aren't pruned, since pruning could delete a run that's still going.Checks
swift test --package-path Tools/TranscriptedQA --filter SparkleUpdateSmokeTests: pass (6 tests, 0 failures)<output>/<state>path back temporarily and ran the new test: it failed on both the path-equality and "run A's report still exists" asserts. Restored.python3 scripts/dev/check-source-pins.py --changed-only: passpython3 scripts/dev/check-test-shape.py: passbash check.sh: pass (Deterministic proof PASS, 95 TranscriptedQA tests, doc paths OK)bash run-tests.shandverify-change.sh(no app-target code changed; this is QA tooling only). The real-app smoke itself wasn't run.Review
Independent review by Opus over the Sonnet diff, against
origin/main(branch was already current). Verdict: correct and complete for the one checklist item. No privacy, audio, main-thread or product-surface impact. Harness safety is better than before: the stale-report delete now only ever runs inside a fresh UUID folder. No checks weakened, no baselines grown, the test doesn't readSources/as text, and it's a real regression test (fails on the old layout). No changes needed on top of Sonnet's commit.Labeled
needs owner reviewbecause it touches the Sparkle smoke tooling.Fixes #2157
🤖 Generated with Claude Code