Repository navigation
fix(qa): contain Sparkle smoke artifacts within owned run directories - #2254
Merged
Merged
Conversation
Each sparkle-update-smoke run now writes its launch report, app log and isolated home under <output>/runs/<runID>/<state>, so two overlapping runs on the same output can no longer delete or consume each other's report. Adds a test with two runs sharing one output. Fixes #2157
Reject symlinked run ancestors and launch artifacts before creating or launching scenario state. Add synthetic regressions for every directory level and traversal inputs.
Owner
Author
|
Final review: the complete repair diff was independently approved, its original defect reproduced, and its regression tests passed. Exact repair-head CI is green. Combined candidate 75488fb passed mapped checks, fresh full deterministic QA/build and safe synthetic paste verification; see #2255 for evidence and the explicit native, thin-packaging and release limitations. Ready for the owner-authorized ancestry-preserving integration; no release or live hardware clearance is implied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Fixes #2250. Builds on #2218. Validate each owned per-run directory component before descending/creating it; reject symlinked reports/logs and escaping run/state identifiers before cleanup, writes or launch. Preserve concurrent-run isolation and the explicit output root's supported canonical alias.
Evidence
This is bounded harness containment, not a claim of race-free behavior under a hostile concurrent filesystem swap. Native account-isolation guard remains unchanged.