Repository navigation
Sweep fix: Sparkle update smoke ignores a stale launch report - #2107
Merged
Merged
Conversation
runScenario never removed launch-ui-smoke.json from a previous run, and the default --output is a fixed /tmp path, so an app that crashed before reporting would decode the old report and PASS. Remove it before the launch so only this run's report counts.
r3dbars
marked this pull request as ready for review
October 8, 2026 10:22
r3dbars
added
the
waiting-on-human
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 540ed48310
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ed scenario folder
1 task
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #2101 (one PR per bug). Confirmed bug from the Haiku sweep.
What was wrong
SparkleUpdateSmoke.runScenarionever removedlaunch-ui-smoke.jsonfrom an earlier run, and the default--outputis a fixed /tmp path. If the app crashed or never reported this time, the smoke decoded the old report and passed.Failing test
SparkleUpdateSmokeTests.testScenarioDoesNotPassOnLaunchReportLeftByEarlierRun: a passing report from an earlier run is left in the scenario folder, and the "app" is a shell script that writes nothing. Before the fix the scenario passed; now it fails onlaunch-report. Red then green.testScenarioPassesOnLaunchReportWrittenByThisLaunch: a report written by this launch still counts.runScenariowent from private to internal so the test can drive it without the native-smoke isolation gate. The fake app is a shell script, never the real app.Fix
Delete the old report before launching.
Checks
swift test --package-path Tools/TranscriptedQA: 94 tests passbash check.sh: PASSIndependent review: approve with nits (3 rounds, reviewed as part of #2101). No nits for this fix.
🤖 Generated with Claude Code