Skip to content

Raise a clear ValueError for negative ndigits in intcomma #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ozenyunus35 wants to merge 1 commit into from
+13 −0
Closed

Raise a clear ValueError for negative ndigits in intcomma #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/humanize/number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,16 @@ def intcomma(value: NumberOrString, ndigits: int | None = None) -> str:

Returns:
str: String containing commas every three digits.

Raises:
ValueError: If `ndigits` is negative.
"""
import math

if ndigits is not None and ndigits < 0:
msg = f"ndigits must be >= 0, got {ndigits}"
raise ValueError(msg)

thousands_sep = thousands_separator()
decimal_sep = decimal_separator()
try:
Expand Down
6 changes: 6 additions & 0 deletions tests/test_number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ def test_intcomma(
assert humanize.intcomma(*test_args) == expected


@pytest.mark.parametrize("value", [12345.111, 12345, "12345.111", None])
def test_intcomma_negative_ndigits(value: float | str | None) -> None:
with pytest.raises(ValueError, match="ndigits must be >= 0"):
humanize.intcomma(value, -1)


@pytest.mark.parametrize("sign", [1, -1])
def test_intcomma_large_integer(sign: int) -> None:
value = sign * (10**400 + 123)
Expand Down