Repository navigation
Raise a clear ValueError for negative ndigits in intcomma - #468
Closed
ozenyunus35 wants to merge 1 commit into
Closed
ozenyunus35 wants to merge 1 commit into
ozenyunus35 wants to merge 1 commit into
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #466
Changes proposed in this pull request:
intcomma(value, ndigits)with a negativendigitsused to fail withValueError: Format specifier missing precisionfrom the f-string. It now raisesValueError: ndigits must be >= 0, got -1before doing anything else, as suggested in the issue, and the docstring lists it underRaises.test_intcomma_negative_ndigitsfor float, int, numeric string andNonevalues; it fails on main.An alternative would be to round to tens/hundreds like
round(x, -1), but the docstring describesndigitsas digits after the decimal point, so an error seemed like the smaller change. Happy to switch if you'd prefer that.I used an AI assistant to help draft parts of the code and tests; I reviewed the changes and ran the tests myself.