Repository navigation
Remove deprecated FacetGrid.axes property - #11766
Open
pereradrian wants to merge 2 commits into
Open
pereradrian wants to merge 2 commits into
pereradrian wants to merge 2 commits into
Conversation
Deprecated since v2022.11.0 (pydata#7194); use FacetGrid.axs instead. Also update the documentation examples that still used it. Part of pydata#11721. Co-authored-by: Claude <noreply@anthropic.com>
Author
|
Could someone rerun the failing test-py314 (flaky) job? The xdist workers crashed unexpectedly while running the PyDAP/DataTree tests, and the failure doesn't appear related to this PR. All other CI jobs passed. Thanks! |
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #11721 (the "Plotting: … remove
FacetGrid.axes…" item).FacetGrid.axeshas emitted aFutureWarningsince v2022.11.0 (#7194), pointing users toFacetGrid.axs. This PR removes the property and its setter.Changes:
axesproperty and setter fromxarray/plot/facetgrid.py.test_facetgrid_axes_raises_deprecation_warning, which only tested the warning.FacetGrid:doc/gallery/plot_cartopy_facetgrid.pyanddoc/examples/visualization_gallery.ipynb(p.axes.flat→p.axs.flat). Thep.axescalls indoc/user-guide/plotting.mdare left unchanged, because that plot has nocol/rowand returns a matplotlib artist, not aFacetGrid.whats-new.rst.The other plotting items in that bullet (positional args, 1D
hue_style=) are not included, to keep this PR focused.Checklist
whats-new.rstAI Disclosure
Tools: Claude Code (Claude Opus 5.5). I asked it to find a beginner-friendly open task in Tracking: open deprecations #11721, implement the
FacetGrid.axesremoval following the pattern of Remove deprecated dt.weekofyear and dt.week accessors #11742, and run the plotting tests (pytest xarray/tests/test_plot.py: 580 passed) andruff.[This is Claude Code on behalf of Adrián Muñoz Perera]