Repository navigation
Import AGENTS.md from CLAUDE.md and use pixi in the agent instructions - #11774
Merged
Merged
Conversation
Claude Code before v2.1.277 doesn't read AGENTS.md, and newer versions skip it when a CLAUDE.md exists in a parent directory. A CLAUDE.md that imports AGENTS.md works in both cases. The test guidelines move to xarray/tests/AGENTS.md, so that other agents read them too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@dcherian I noticed that you seem to be against parametrizing tests e.g. for with and without dask (as per your previous instructions in the agents file). Is the approach with using the |
Contributor
|
Uhh... i withdraw that objection. I prefer not doing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #11753: agents still ignore
AGENTS.md, e.g. asking for reruns of the flaky job in #11766.CLAUDE.mdthat importsAGENTS.md: Claude Code before v2.1.277 doesn't readAGENTS.md, and newer versions skip it if there is aCLAUDE.mdin a parent directory or aCLAUDE.local.md.xarray/tests/AGENTS.mdso that other agents read them too, withxarray/tests/CLAUDE.mdimporting it, and reference them fromAGENTS.md.use_daskfixture orpytest.param(..., marks=requires_*)over separate tests, which avoids duplicate code and checks that numpy and dask give the same result. Mention that shared fixtures are inxarray/tests/conftest.py, drop the "Common patterns" section (it contradicted this and used a function that doesn't exist) and update the CI environment names.pytest.importorskipexamples in the test guidelines: tests should be skipped at collection time with therequires_*decorators.uvfor running tests and mypy, andpixi exec pre-commit(thepre-commitpixi task always succeeds).AI Disclosure
Tools: Claude Code with Opus 5.5
🤖 Generated with Claude Code