Skip to content

perf(mobile,tv): a page of rows reaches the screen only with its text built - #838

Merged
altaywtf merged 7 commits into
mainfrom
fix/833-row-text-before-ui
Nov 15, 2026
Merged

altaywtf merged 7 commits into
mainfrom
fix/833-row-text-before-ui

Conversation

@altaywtf

@altaywtf altaywtf commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Change

A cold-opened page of rows reaches the screen only with its text already built off the main thread. Closes #833.

Screen Gate
Mobile Files, Trash, Search RowText.shown
TV Files, Search, Trash RowText.shown, skeleton while building
Mobile and TV History rememberBuiltOffMain (unchanged)
  • Paging and the Files viewport follow the shown page.
  • Mobile tests build row text in step (setBuiltContent).

Validation

  • ./gradlew verify and both debug assembles
  • aLoadedPageComposesNoRowBeforeItsTextIsBuilt fails on main, passes here
  • Cold open on Pixel 8a and Mi Box 4: frames with a blank meta line
List main This PR
Pixel Files 2, 2 0, 0
Pixel Trash 2, 2 0, 0
TV Files 6, 4 0, 0

Fix reverted on Pixel Files: 2.

Unverified: Search on devices.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T10:30:17.177792Z 98004d1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf

altaywtf commented Nov 15, 2026 •

Copy link
Copy Markdown
Member Author

Cold open on devices: frames where the first row shows its name but a blank meta line.

Device List main This PR Fix reverted
Pixel 8a Files 2, 2 0, 0 2
Pixel 8a Trash 2, 2 0, 0 —
Mi Box 4 TV Files 6, 4 0, 0 —
TV Files: main shows names without meta, PR shows skeleton

TV Files, first frame after opening: main (left) vs this PR (right, skeleton until the text is built).

  • screenrecord per run; frames counted by ink in the first row's name and meta strips.
  • Fix reverted: RowText.shown returns source unconditionally.

@altaywtf
altaywtf merged commit c570e16 into main Nov 15, 2026
5 checks passed
@altaywtf
altaywtf deleted the fix/833-row-text-before-ui branch November 15, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(mobile): first page of rows flashes blank meta lines on a cold open

1 participant