Skip to content

fix(mobile,tv): lists, details and paging follow one built page - #839

Merged
altaywtf merged 6 commits into
mainfrom
fix/perf-audit-followups
Nov 15, 2026
Merged

altaywtf merged 6 commits into
mainfrom
fix/perf-audit-followups

Conversation

@altaywtf

@altaywtf altaywtf commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Change

Lists, detail panes and paging follow the one page whose row text is built, closing audit findings on #812–#838.

  • TV Trash and Search skeletons take list focus, and hand it to the first row once rows show.
  • TV Trash and Search page only from the rows they show, like Files.
  • TV detail panes and actions read the shown page.
  • A remounted pane restores focus to a section that mounts a frame late.
  • Identity keys replace whole-list compares.
  • RowText drops stale waiting requests.

Validation

  • ./gradlew verify, both debug assembles, TV baseline profile regenerated
Test main This PR
Trash skeleton takes entry focus no node focused passes
Trash refresh keeps the dropped row's detail detail gone passes
Files sort near the end pages once 2 loads passes
Search skeleton hands focus to the first row no row focused passes
Search new query pages once its rows show 1 stale load passes
Trash refresh pages once its rows show 1 stale load passes

Device QA (proof comment): main passes Files, Refresh and Search on the Mi Box. The PR build is unverified on device: the Pixel was locked and the Mi Box was casting.

…r it

Gating Trash's detail on the shown page mounts the Restore action a frame
after the pane's restoreLastSection runs, so the saved section was never
found and entry fell back to the rows. The owner now keeps the restore
pending until that section registers, unless focus enters elsewhere first.

Also: the Trash skeleton entry test asserts focus, detekt findings in
Search and mobile Files are fixed, and the TV baseline profile is
regenerated.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T12:42:04.709341Z 07f0164 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

… show

The Search results skeleton could take focus and drop it when the rows
mounted. Trash and Search also paged from stale rows while a refresh or
new query built its text.
@altaywtf

Copy link
Copy Markdown
Member Author

Proof

Tests, main behaviour vs this branch (fix reverted as the negative control for the last three):

Test Without fix Branch
TvTrashScreenTest.enteringThePaneWhileTheFirstRowsBuildLandsOnTheSkeleton no node focused passes
TvTrashScreenTest.aRefreshThatDropsTheFocusedRowKeepsItsDetailUntilTheNewRowsShow detail gone passes
MobileFilesListTest.aSortLandingNearTheEndPagesOnlyOnceItsRowsShow expected:<1> but was:<2> passes
TvSearchRowsBuildTest.enteringTheResultsWhileTheirRowsBuildLandsOnTheFirstRowOnceTheyShow row not focused passes
TvSearchRowsBuildTest.aNewQueryPagesOnlyOnceItsRowsShow expected:<[]> but was:<[next]> passes
TvTrashScreenTest.aRefreshPagesOnlyOnceItsRowsShow expected:<[]> but was:<[LoadNextPage]> passes

Device QA:

Scenario Pixel main / PR Mi Box main Mi Box PR
Files not run (locked) pass not run (Cast session)
Refresh, leave, return not run pass not run
Search not run pass; paging unverified not run
History not run not checked not run
Trash and Restore not run partial; Restore unconfirmed not run
  • No FATAL or IllegalStateException in app logcat on main.
  • PR build unverified on device: the Pixel keyguard was locked and another session was casting to the Mi Box.

@altaywtf
altaywtf merged commit 93f871b into main Nov 15, 2026
5 checks passed
@altaywtf
altaywtf deleted the fix/perf-audit-followups branch November 15, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant