Repository navigation
fix(mobile,tv): lists, details and paging follow one built page - #839
Merged
Merged
Conversation
…r it Gating Trash's detail on the shown page mounts the Restore action a frame after the pane's restoreLastSection runs, so the saved section was never found and entry fell back to the rows. The owner now keeps the restore pending until that section registers, unless focus enters elsewhere first. Also: the Trash skeleton entry test asserts focus, detekt findings in Search and mobile Files are fixed, and the TV baseline profile is regenerated.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
… show The Search results skeleton could take focus and drop it when the rows mounted. Trash and Search also paged from stale rows while a refresh or new query built its text.
Member
Author
ProofTests,
Device QA:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Lists, detail panes and paging follow the one page whose row text is built, closing audit findings on #812–#838.
Identitykeys replace whole-list compares.RowTextdrops stale waiting requests.Validation
./gradlew verify, both debug assembles, TV baseline profile regeneratedmainDevice QA (proof comment):
mainpasses Files, Refresh and Search on the Mi Box. The PR build is unverified on device: the Pixel was locked and the Mi Box was casting.