Skip to content

"Last checked" time format: Apply GNOME user settings for 12h/24h #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
purejava merged 2 commits into from
Jul 13, 2026
Merged

"Last checked" time format: Apply GNOME user settings for 12h/24h #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a1ccb
Apply GNOME user settings to "Last cheched" date and time format.
marinierb Jul 13, 2026
b3c7aed
Update extension.js
marinierb Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,10 @@ class FedoraUpdateIndicator extends Button {

// Load settings
this._settings = this._extension.getSettings();
this._desktopSettings = new Gio.Settings({ schema_id: 'org.gnome.desktop.interface' });
this._settingsPositionChangedId = this._settings.connect('changed', this._positionChanged.bind(this));
this._settingsChangedId = this._settings.connect('changed', this._applySettings.bind(this));
this._desktopSettingsChangedId = this._desktopSettings.connect('changed::clock-format', this._updateLastCheckMenu.bind(this));
this._applySettings();

if (FIRST_BOOT) {
Expand Down Expand Up @@ -328,6 +330,10 @@ class FedoraUpdateIndicator extends Button {
this._settings.disconnect(this._settingsChangedId);
this._settingsChangedId = null;
}
if (this._desktopSettingsChangedId) {
this._desktopSettings.disconnect(this._desktopSettingsChangedId);
this._desktopSettingsChangedId = null;
}
}
if (this._notifSource) {
// Delete the notification source, which lay still have a notification shown
Expand Down Expand Up @@ -430,8 +436,19 @@ class FedoraUpdateIndicator extends Button {
}
}

_formatLastCheckedTime() {
if (!LAST_CHECK) {
return '';
}

const date = GLib.DateTime.new_from_unix_local(Math.floor(LAST_CHECK.getTime() / 1000));
const clockFormat = this._desktopSettings?.get_enum('clock-format') ?? 0;
const timeFormat = clockFormat === 1 ? '%x %I:%M %p' : '%x %H:%M:%S';
return date.format(timeFormat);
}

_updateLastCheckMenu() {
this.timeCheckedMenu.label.set_text( _("Last checked") + " " + LAST_CHECK.toLocaleString() );
this.timeCheckedMenu.label.set_text( _("Last checked") + " " + this._formatLastCheckedTime() );
this.timeCheckedMenu.visible = SHOW_TIMECHECKED;
}

Expand Down