"Last checked" time format: Apply GNOME user settings for 12h/24h#49
Merged
Conversation
marinierb
changed the title
Owner
|
Thank you very much for your well-written PR. That's a nice improvement! However, I'd suggest a litte change inline. |
purejava
requested changes
Jul 13, 2026
Co-authored-by: Ralph Plawetzki <ralph@purejava.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the "Last checked" timestamp used Date.toLocaleString(), ignoring the user's GNOME 12h/24h clock preference. This reads org.gnome.desktop.interface's clock-format key and formats the time accordingly (%I:%M %p for 12h, %H:%M for 24h), updating live if the user changes the setting while the extension is running.