Repository navigation
Conversation
Contributor
Author
…rk guard Fails on main as of c7ad6ea: the `changes` jobs in ci.yml and systest.yml run on a literal [self-hosted, linux, x64, light] list and execute the PR's own tools/ci/detect-changes.sh, so a fork PR runs its code on the pool. Found by the v0.48.0 clean-room review. The fix follows in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z
Both ran on a literal [self-hosted, linux, x64, light] list for every pull_request and executed the PR's own tools/ci/detect-changes.sh, so a fork PR ran its code on the pool. They now use the same fail-closed guard as every other job: the pool only for a non-PR event or a head repository that is this repository, otherwise ubuntu-24.04. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z
avrabe
force-pushed
the
ci/changes-job-fork-guard
branch
from
November 19, 2026 15:46
a9f9e49 to
4d479e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
changesjobs inci.yml(line 24) andsystest.yml(line 45) run on a literal[self-hosted, linux, x64, light]list for every pull_request. They execute the PR checkout's owntools/ci/detect-changes.sh. A fork PR, including one from a deleted fork, therefore runs its own code on the self-hosted pool. #370 guarded every other job and missed these two. The v0.48.0 clean-room review found it.Test first.
no_pull_request_job_reaches_the_pool_without_the_fork_guard(runner_trust_boundary.rs) fails for anyruns-onthat names self-hosted in a pull_request-triggered workflow without thehead.repo.full_name == github.repositoryguard. The first head (4819653e) carries only the test, and it must go red on these two lines. The fix commit follows.Fix. Both jobs use the same fail-closed guard as the rest: the pool only when the event is not a pull_request or the head repository is this repository; otherwise
ubuntu-24.04.mutants.yml:156also uses a literal list. It runs only on schedule and workflow_dispatch, so no fork reaches it, and the test skips it for that reason.🤖 Generated with Claude Code
https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z