Repository navigation
Conversation
Tests only; each red one fails against main for the reason named. - runwith: a shebang line over 127 bytes is refused (Linux before 5.1 reads 128 bytes of it and silently cuts the interpreter's path); the existing bounds test moves from 255 to 127. - detect-changes: code moved to a .md path outside crates/ must run everything (rename detection listed only the new name). - no-key-on-disk --self-test: quoted secret bindings, redirects with no space, a pipe through another command, and secrets['X'] / secrets["X"] must each be rejected; `2>&1` must still be accepted. - pr_gates: the reader scan must flag secrets['X'] and vars["X"], and every workflow a pull request runs must be listed in PR_WORKFLOWS. - install: an override layer already in the store, below its line's high-water mark, must be refused by install as verify refuses it. - Guards (pass on main by design): the release DSSE step exits 1 with no key; an override naming another layer of the same line is refused; the seed first-contact refusal names the ROOT layer's line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z
- run --with: a Linux build refuses a wrapper whose first line would exceed 127 bytes (Linux before 5.1 reads 128 and silently truncates the interpreter path), before anything is created, naming the limit and suggesting a shorter TMPDIR. A macOS build keeps the 255 bound: macOS reads 512, and its canonical default TMPDIR alone is over 53. - detect-changes: diff with --no-renames, so a move lists both names and code moved to a .md path outside crates/ runs everything. - no-key-on-disk: catch quoted secret bindings, `>f` / `>>f`, a pipe through one command before the redirect, and secrets['X'] / secrets["X"]; `>&N` is still not a file write. - pr_gates: the reader scan sees vars['X'] / secrets['X'], and gate-probe.yml (on: pull_request) is in PR_WORKFLOWS. - install: an override layer already in the store is held to its line's high-water mark, as verify holds it. - docs: cmd-run states the shebang limit; cmd-install the override mark check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z
cmd-status.md and DD-043 now say that a yanked override layer is not reported and status exits on the pinned layer's verdict (varve#381), and that VARVE_LAYER, the attestation statement and outdated name the pinned layer only (varve#378). Both are kept for v0.49.0 by the maintainer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z
Contributor
Author
|
Tests-only head
Not observed red: Real head pushed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the findings of the v0.48.0 clean-room review that the maintainer put in scope for v0.48.0 (2026-11-19). The fork-guard finding is fixed separately in #377. #378, #379, #380 and #381 are v0.49.0.
Fixes
run --withshebang length. The wrappers are#!<tmpdir>/.v/varve --varve-with-shimscripts. Linux kernels before 5.1 (RHEL 8: 4.18) read 128 bytes of a shebang and truncate silently, so a long TMPDIR could cut the interpreter path to a name another user can create in a sticky/tmp. varve now refuses a first line over 127 bytes on Linux, before anything is created. macOS keeps 255: it reads 512 bytes, and its default TMPDIR resolves to about 56 bytes, which 127 would refuse for every user. Documented in cmd-run.md.detect-changes.shrenames. It now uses--no-renames, so code moved to a.mdpath outsidecrates/no longer classifies as docs-only.no-key-on-disk.shnow catches four more ways of writing a secret to a file: a quoted env binding,>filewith no space, a secret piped through another command into a file, andsecrets['X']. The PR-workflow reader scan also catchessecrets[/vars[, and covers gate-probe.yml.installof an override layer already in the store now checks the high-water mark, asverifydid. It used to accept what verify refused.Guards (pass on main by design):
Limits stated for v0.48.0: cmd-status.md and DD-043 name #381 (yanked override layer not reported) and #378.
Gate. CI is the first run, on the maintainer's call. The first head (
20e73e47) carries only the tests, and these are predicted red:a_shebang_longer_than_an_old_kernel_reads_is_refused_naming_the_limitanda_wrapper_is_one_shebang_line_naming_varve_and_nothing_a_shell_reads(Linux job);test_code_moved_to_a_markdown_path_runs_everything(python tool tests);no-key-on-disk.sh --self-test: 9 must-reject cases accepted;the_reader_scan_flags_env_run_and_with_but_not_comments(secrets index) andevery_workflow_a_pull_request_runs_is_checked(gate-probe.yml);an_override_layer_already_installed_below_its_lines_mark_is_refused_by_install.Fixes (
4eeb2e99) and docs (5b579abe) follow once these are seen red.🤖 Generated with Claude Code
https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z