Skip to content

feat(cli): rivet review export — commit-pinned JSON snapshot of a release (REQ-416) - #1298

Queued
avrabe wants to merge 4 commits into
mainfrom
feat/review-export
Queued

avrabe wants to merge 4 commits into
mainfrom
feat/review-export

Conversation

@avrabe

@avrabe avrabe commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Closes #1227. Replaces #1232, which another session opened 2026-11-12. This session does not push to another session's branch, so #1232's two commits are carried onto this branch unchanged, plus two follow-up commits:

  • Carry onto main: conflicts in requirements.yaml and cmd/mod.rs keep both sides. The CHANGELOG entry and the rivet docs review-export example (v0.42.0 -> v0.43.0, which docs check requires) are moved or updated.
  • Ships after v0.43.0 (owner decision 2026-11-19): the entry sits in [Unreleased], and REQ-416 is scoped to v0.44.0.

The feature itself is unchanged from #1232. Its description has the acceptance criteria and design notes: rivet review export --release vX [--since <ref>] --format json, a commit-pinned snapshot that refuses a dirty tree, with the --since delta, the rivet docs review-export topic and the schemas/json/review-export-output.schema.json contract.

Evidence on this branch

  • review_export and json_output_contracts: 10/10 passed.
  • Before the v0.43.0 rebase: nextest --all --profile ci 2786 passed, 3 skipped; fmt and clippy --all-targets -D warnings (default and --no-default-features) clean; traceability ratchet 0 new.
  • After it: rivet docs check 0 violations (the released [0.43.0] section matches the tag) and rivet validate PASS.

REQ-416 stays implemented. Verifying it needs an independent acceptance review, which happens in the v0.44.0 scope.

Refs: REQ-416

🤖 Generated with Claude Code

https://claude.ai/code/session_015HMQUV3u86jN2hmCtXNTc9

claude and others added 4 commits November 19, 2026 19:15
…ease

`rivet review export --release vX [--since <ref>] [--format json]` emits
{command, commit, release, since, count, artifacts[]} where each artifact
carries id, type, title, status, release, description, tags, fields,
links and provenance. A dirty working tree (any porcelain entry,
untracked included) exits 1 naming every dirty path. `--since <ref>`
loads the project at <ref> via the existing git-archive baseline loader
and reports only added/removed/changed artifacts for vX, with
changed_fields on changed ones.

Shape is pinned by schemas/json/review-export-output.schema.json, a
contract test in json_output_contracts.rs, and documented as the
`review-export` docs topic.

Closes #1227

Implements: REQ-416
Verifies: REQ-416
Refs: REQ-007

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KEjmjZqkpapN4wvGGZwHUo
The traceability ratchet flagged REQ-416 (implemented) as new
requirement-coverage debt: no feature or design decision satisfied it.
FEAT-141 records the review-export feature and closes the gap.

Refs: REQ-416

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KEjmjZqkpapN4wvGGZwHUo
Cherry-picking #1232's two commits (from another session) onto main
after v0.42.2 put its CHANGELOG entry inside the released [0.42.2]
section and duplicated the [0.42.0] heading; the entry moves to
[Unreleased] / Added. The review-export docs topic's example used
v0.42.0, which docs check refuses now that the workspace is 0.43.0; it
uses v0.43.0, and docs/reference is regenerated. requirements.yaml and
cmd/mod.rs conflicts kept both sides: REQ-416 follows REQ-417/418, and
cmd/mod.rs declares both review and supplier.

Refs: REQ-416

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015HMQUV3u86jN2hmCtXNTc9
v0.43.0 was cut without #1232 (owner decision 2026-11-19: review export
waits for v0.44.0). After rebasing onto the tag, the CHANGELOG entry
landed inside the released [0.43.0] section; it moves to [Unreleased],
and REQ-416 moves from v0.43.0 to v0.44.0.

Refs: REQ-416

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015HMQUV3u86jN2hmCtXNTc9

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 44660a1 Previous: 593c0d3 Ratio
store_lookup/10000 375077 ns/iter (± 1203) 303035 ns/iter (± 1320) 1.24

This comment was automatically generated by workflow using github-action-benchmark.

@avrabe
avrabe added this pull request to the merge queue Nov 19, 2026
Any commits made after this event will not be merged.
@github-actions

Copy link
Copy Markdown

📐 Rivet artifact delta

Change Count
Added 2
Removed 0
Modified 0
Downstream impacted (depth ≤ 5) 0

Graph

graph LR
  FEAT_141["FEAT-141"]:::added
  REQ_416["REQ-416"]:::added
  classDef added fill:#d4edda,stroke:#28a745,color:#155724
  classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
  classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
  classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Loading
Added
  • FEAT-141
  • REQ-416

📎 Full HTML dashboard attached as workflow artifact rivet-delta-pr-1298 — download from the workflow run.

Posted by rivet-delta workflow. The graph shows only changed artifacts; open the HTML dashboard (above) for full context.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rivet review export: a commit-pinned JSON snapshot of a release's artifacts for review

2 participants