Repository navigation
Conversation
…ease
`rivet review export --release vX [--since <ref>] [--format json]` emits
{command, commit, release, since, count, artifacts[]} where each artifact
carries id, type, title, status, release, description, tags, fields,
links and provenance. A dirty working tree (any porcelain entry,
untracked included) exits 1 naming every dirty path. `--since <ref>`
loads the project at <ref> via the existing git-archive baseline loader
and reports only added/removed/changed artifacts for vX, with
changed_fields on changed ones.
Shape is pinned by schemas/json/review-export-output.schema.json, a
contract test in json_output_contracts.rs, and documented as the
`review-export` docs topic.
Closes #1227
Implements: REQ-416
Verifies: REQ-416
Refs: REQ-007
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KEjmjZqkpapN4wvGGZwHUo
The traceability ratchet flagged REQ-416 (implemented) as new requirement-coverage debt: no feature or design decision satisfied it. FEAT-141 records the review-export feature and closes the gap. Refs: REQ-416 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjZqkpapN4wvGGZwHUo
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📐 Rivet artifact delta
Graphgraph LR
FEAT_141["FEAT-141"]:::added
REQ_416["REQ-416"]:::added
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Added
Posted by |
avrabe
added a commit
that referenced
this pull request
Nov 19, 2026
Cherry-picking #1232's two commits (from another session) onto main after v0.42.2 put its CHANGELOG entry inside the released [0.42.2] section and duplicated the [0.42.0] heading; the entry moves to [Unreleased] / Added. The review-export docs topic's example used v0.42.0, which docs check refuses now that the workspace is 0.43.0; it uses v0.43.0, and docs/reference is regenerated. requirements.yaml and cmd/mod.rs conflicts kept both sides: REQ-416 follows REQ-417/418, and cmd/mod.rs declares both review and supplier. Refs: REQ-416 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015HMQUV3u86jN2hmCtXNTc9
avrabe
added a commit
that referenced
this pull request
Nov 19, 2026
v0.43.0 was cut without #1232 (owner decision 2026-11-19: review export waits for v0.44.0). After rebasing onto the tag, the CHANGELOG entry landed inside the released [0.43.0] section; it moves to [Unreleased], and REQ-416 moves from v0.43.0 to v0.44.0. Refs: REQ-416 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015HMQUV3u86jN2hmCtXNTc9
Contributor
Author
|
Superseded by #1298. This PR's two commits are carried there unchanged, rebased onto main after v0.43.0 (conflicts in requirements.yaml and cmd/mod.rs keep both sides). The owner decided 2026-11-19 that review export ships after v0.43.0, so REQ-416 is scoped to v0.44.0. Closed rather than force-pushed because this branch belongs to another session. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1227
Adds
rivet review export --release vX [--since <ref>] [--format json](new modulerivet-cli/src/cmd/review.rs, requirement REQ-416, satisfied by feature FEAT-141).Acceptance criteria
rivet review export --release vX --format jsonemitscommit,releaseand every artifact scoped to vX, provenance included. Output is{command, commit, release, since, count, artifacts[]}.commitis the full 40-chargit rev-parse HEAD. Scope uses the same predicate asrivet list --release vX, and a test asserts the id sets match. Each artifact carries id, type, title, status, release, description, tags, fields, fields_per_variant, links and provenance. Tested inrivet-cli/tests/review_export.rs. On a clean clone of this repo,--release v0.42.0exports 12 artifacts, the same 12 thatrivet list --release v0.42.0returns.git status --porcelain --untracked-files=all. Any entry, untracked files included (rivet would load them), exits 1 with empty stdout and lists every dirty path on stderr. Covered by an integration test.--since <sha>reports exactly the added, removed and changed artifacts for vX, with a test covering all three. The project at<sha>is loaded with the existinggit archivebaseline loader (load_baseline_from_git, nowpub(crate), not duplicated). Each artifact gets achangeofadded,removedorchanged, and changed ones also getchanged_fields(top-level keys). Moving into or out of vX counts as added or removed. Removed artifacts carry their content as of<sha>. Unchanged artifacts are left out. The integration test covers one artifact of each kind and checks that an unchanged one is absent. There is also a unit test of the delta logic.rivet docsand covered by a schema or snapshot test.rivet docs review-exporttopic, exported todocs/reference/review-export.md.schemas/json/review-export-output.schema.json, withadditionalProperties: falseand an enum onchange. It is registered inJSON_SCHEMA_REGISTRY, so it appears inrivet schema list-json.json_output_contracts.rs: validates real output, both a full export and a--sincedelta, against the schema, and checks that a badchangevalue, an extra key and a short commit sha are each rejected.Design notes for the reviewer
statusanddescriptionarenull, not""as inrivet get, so consumers can tell "unset" apart from "empty".changed_fieldsreports a change inside a custom field asfields; it does not list sub-keys.jsonis supported, and it is the default.provenance.reviewed-by, review date and outcome) is out of scope, as the issue says. It depends on No command writes provenance.reviewed-by, yet ai-generated-needs-review requires it (--set-field writes a dotted key instead of a nested one) #1057.Verification
cargo fmt --all -- --check: cleancargo clippy --all-targets -- -D warningsandcargo clippy -p rivet-cli --no-default-features -- -D warnings: cleancargo test -p rivet-cli --test review_export: 4/4 passed--test json_output_contracts: 6/6 passed--test cli_commands: 275/275 passed--test docs_check --test docs_coverage: all passed--bin rivet: 172/172 passedrivet validate: PASS (853 → 855 warnings). The two new warnings areai-generated-needs-reviewon REQ-416 and FEAT-141, becauseprovenance.reviewed-byis unset (REQ-415 and FEAT-140 have the same warning).main: 0 new gated findings, after FEAT-141 was added to satisfy REQ-416.rivet docs check: the same 5 pre-existing ChangelogStructure violations asmain(no tags in a shallow clone, plus old duplicate headings), and nothing new.06792e1: all checks passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01KEjmjZqkpapN4wvGGZwHUo