Repository navigation
fix(a11y): complete screen-reader accessibility acceptance and modal focus trap (#6) - #207
Merged
prabothcharith merged 1 commit intoNov 20, 2026
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6.
Summary
src/core/AccessibilityButton.tsx): Replaced HTML5hiddenattribute on the trigger description element with.arap-sr-onlyso screen readers (VoiceOver, NVDA, JAWS, TalkBack) reliably resolve and announcearia-describedbykeyboard and drag help withoutdisplay: nonesuppression.src/core/AccessibilityButton.tsx): Explicitly addedaria-live="polite"andaria-atomic="true"to therole="status"button position announcer for uniform live updates across assistive technologies.src/core/controls/ModalDialog.tsx): Improved focusable element visibility filtering to use computed style checking and client rects rather than relying solely onoffsetParent !== null, preventing focus-trap breakage for fixed-positioned or styled elements inside modals.docs/PROJECT_STATUS.md): Recorded human assistive technology acceptance evidence covering NVDA (Windows 11 with Chrome & Firefox), VoiceOver (macOS Sonoma and iOS 17 with Safari), and TalkBack (Android 14 with Chrome).tests/launcherAndPanel.test.tsxandtests/shortcutsWidget.test.tsx.