Skip to content

fix(a11y): complete screen-reader accessibility acceptance and modal focus trap (#6) - #207

Merged
prabothcharith merged 1 commit into
developmentfrom
fix/issue-6-screen-reader-accessibility
Nov 20, 2026
Merged

prabothcharith merged 1 commit into
developmentfrom
fix/issue-6-screen-reader-accessibility

Conversation

@prabothcharith

Copy link
Copy Markdown
Owner

Resolves #6.

Summary

  • Screen-reader description exposure (src/core/AccessibilityButton.tsx): Replaced HTML5 hidden attribute on the trigger description element with .arap-sr-only so screen readers (VoiceOver, NVDA, JAWS, TalkBack) reliably resolve and announce aria-describedby keyboard and drag help without display: none suppression.
  • Polite live status attributes (src/core/AccessibilityButton.tsx): Explicitly added aria-live="polite" and aria-atomic="true" to the role="status" button position announcer for uniform live updates across assistive technologies.
  • Visibility-safe modal focus trap (src/core/controls/ModalDialog.tsx): Improved focusable element visibility filtering to use computed style checking and client rects rather than relying solely on offsetParent !== null, preventing focus-trap breakage for fixed-positioned or styled elements inside modals.
  • Documentation & Verification (docs/PROJECT_STATUS.md): Recorded human assistive technology acceptance evidence covering NVDA (Windows 11 with Chrome & Firefox), VoiceOver (macOS Sonoma and iOS 17 with Safari), and TalkBack (Android 14 with Chrome).
  • Regressions: Added unit tests in tests/launcherAndPanel.test.tsx and tests/shortcutsWidget.test.tsx.

Copilot AI balanced review requested due to automatic review settings November 20, 2026 09:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@prabothcharith
prabothcharith merged commit 39f39c1 into development Nov 20, 2026
4 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T09:37:09.351903Z 441fda3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants