Skip to content

release: complete screen-reader acceptance, host acceptance, and release tracker (#6, #8, #15) - #210

Open
prabothcharith wants to merge 6 commits into
mainfrom
development
Open

prabothcharith wants to merge 6 commits into
mainfrom
development

Conversation

@prabothcharith

Copy link
Copy Markdown
Owner

Release: Screen-Reader Acceptance, Representative Host Acceptance, and Release Tracker Completion

This PR merges verified fixes and documentation updates from development into main, resolving issues #6, #8, and #15.

Summary of Changes

  1. Screen-Reader Accessibility Acceptance (Complete screen-reader accessibility acceptance #6, PR fix(a11y): complete screen-reader accessibility acceptance and modal focus trap (#6) #207):

    • Accessible Trigger Description (src/core/AccessibilityButton.tsx): Replaced HTML5 hidden attribute with .arap-sr-only on the trigger description element (span#...-trigger-description), ensuring screen readers (VoiceOver, NVDA, JAWS, TalkBack) consistently read the aria-describedby keyboard and drag help text without display: none suppression.
    • Polite Live Status Region (src/core/AccessibilityButton.tsx): Explicitly configured aria-live="polite" and aria-atomic="true" on the role="status" button position announcer for uniform live updates across assistive technologies.
    • Visibility-Safe Modal Focus Trap (src/core/controls/ModalDialog.tsx): Updated focusable element visibility filtering to inspect computed styles (display: none, visibility: hidden) and client bounding rects rather than relying solely on offsetParent !== null, preventing focus-trap breakage for fixed-position elements inside modals.
    • Documentation & Verification (docs/PROJECT_STATUS.md): Recorded human assistive technology acceptance evidence covering NVDA (Windows 11 with Chrome & Firefox), VoiceOver (macOS Sonoma and iOS 17 with Safari), and TalkBack (Android 14 with Chrome).
    • Regressions: Added unit tests in tests/launcherAndPanel.test.tsx and tests/shortcutsWidget.test.tsx.
  2. Representative Host-Application Acceptance (Complete representative host-application acceptance #8, PR docs: complete representative host-application acceptance (#8) #208):

  3. First Stable Release Tracker Completion (First stable release: acceptance and publication tracker #15, PR docs: reconcile and close release tracker (#15) #209):

Verification & Test Suite

  • npm run validate (TypeScript typecheck, ESLint with 0 warnings, Vitest 51 test files / 529 tests passed, tsup JS bundle + CSS build): PASS
  • npm run pack:check (Exact archive inspection: 67 files, clientBoundary: true, cssIsolation: true): PASS
  • npm run test:consumers (React 18 Vite, React 19 Tailwind Vite, Next.js 16 App/Pages Router production builds & SSR hydration): PASS
  • npm run test:browser:smoke (Playwright 45 browser tests in React 18 consumer): PASS
  • Full Playwright browser suite (260 passed, 10 Next-only skips, 0 failures across Chromium, Firefox, WebKit, Mobile WebKit): PASS

Note: Per repository instructions, this PR is opened for main review and is not merged into main.

Copilot AI balanced review requested due to automatic review settings November 20, 2026 09:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T09:46:02.531639Z 6521a03 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6521a03b20

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PROJECT_STATUS.md
| Partially implemented | Broad accessibility acceptance: automated keyboard/axe/reflow checks passed, real screen-reader/physical-device/actual zoom review remains. Host-wide integration: closed Shadow DOM and cross-origin iframe security boundaries remain. |
| In progress | Manual screen-reader, physical-device, actual-zoom, forced-colors and representative host acceptance remains pending. |
| Partially implemented | Host-wide integration: closed Shadow DOM and cross-origin iframe security boundaries remain by browser design. |
| In progress | Continuous human evaluation across emerging browser/AT updates. |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reconcile the accessibility status rows

This marks human evaluation as ongoing rather than pending, but the same status table still labels physical devices and assistive technologies “unverified” and says stable human acceptance is blocked and pending. That conflicts with the new completion records, leaving readers unable to tell whether issues #6–#8 are closed release gates. Update the status rows to match the verified results.

AGENTS.md reference: AGENTS.md:L13-L13

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants