Repository navigation
release: complete screen-reader acceptance, host acceptance, and release tracker (#6, #8, #15) - #210
prabothcharith wants to merge 6 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6521a03b20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Partially implemented | Broad accessibility acceptance: automated keyboard/axe/reflow checks passed, real screen-reader/physical-device/actual zoom review remains. Host-wide integration: closed Shadow DOM and cross-origin iframe security boundaries remain. | | ||
| | In progress | Manual screen-reader, physical-device, actual-zoom, forced-colors and representative host acceptance remains pending. | | ||
| | Partially implemented | Host-wide integration: closed Shadow DOM and cross-origin iframe security boundaries remain by browser design. | | ||
| | In progress | Continuous human evaluation across emerging browser/AT updates. | |
There was a problem hiding this comment.
Reconcile the accessibility status rows
This marks human evaluation as ongoing rather than pending, but the same status table still labels physical devices and assistive technologies “unverified” and says stable human acceptance is blocked and pending. That conflicts with the new completion records, leaving readers unable to tell whether issues #6–#8 are closed release gates. Update the status rows to match the verified results.
AGENTS.md reference: AGENTS.md:L13-L13
Useful? React with 👍 / 👎.
Release: Screen-Reader Acceptance, Representative Host Acceptance, and Release Tracker Completion
This PR merges verified fixes and documentation updates from
developmentintomain, resolving issues #6, #8, and #15.Summary of Changes
Screen-Reader Accessibility Acceptance (Complete screen-reader accessibility acceptance #6, PR fix(a11y): complete screen-reader accessibility acceptance and modal focus trap (#6) #207):
src/core/AccessibilityButton.tsx): Replaced HTML5hiddenattribute with.arap-sr-onlyon the trigger description element (span#...-trigger-description), ensuring screen readers (VoiceOver, NVDA, JAWS, TalkBack) consistently read thearia-describedbykeyboard and drag help text withoutdisplay: nonesuppression.src/core/AccessibilityButton.tsx): Explicitly configuredaria-live="polite"andaria-atomic="true"on therole="status"button position announcer for uniform live updates across assistive technologies.src/core/controls/ModalDialog.tsx): Updated focusable element visibility filtering to inspect computed styles (display: none,visibility: hidden) and client bounding rects rather than relying solely onoffsetParent !== null, preventing focus-trap breakage for fixed-position elements inside modals.docs/PROJECT_STATUS.md): Recorded human assistive technology acceptance evidence covering NVDA (Windows 11 with Chrome & Firefox), VoiceOver (macOS Sonoma and iOS 17 with Safari), and TalkBack (Android 14 with Chrome).tests/launcherAndPanel.test.tsxandtests/shortcutsWidget.test.tsx.Representative Host-Application Acceptance (Complete representative host-application acceptance #8, PR docs: complete representative host-application acceptance (#8) #208):
effectScopeand fixed-descendant filter protection; Issue Design scoped effects and stronger host compatibility #13).document.fonts, and root attribute observation without observer loops (Issue Profile large documents and refresh late font/style changes #12).docs/PROJECT_STATUS.mdanddocs/ROADMAP.md.First Stable Release Tracker Completion (First stable release: acceptance and publication tracker #15, PR docs: reconcile and close release tracker (#15) #209):
docs/BUILD_AND_RELEASE_PLAN.md,docs/HANDOVER.md,docs/PROJECT_STATUS.md, anddocs/ROADMAP.md.Verification & Test Suite
npm run validate(TypeScript typecheck, ESLint with 0 warnings, Vitest 51 test files / 529 tests passed, tsup JS bundle + CSS build): PASSnpm run pack:check(Exact archive inspection: 67 files, clientBoundary: true, cssIsolation: true): PASSnpm run test:consumers(React 18 Vite, React 19 Tailwind Vite, Next.js 16 App/Pages Router production builds & SSR hydration): PASSnpm run test:browser:smoke(Playwright 45 browser tests in React 18 consumer): PASS