Skip to content

fix(shared): delete unused agentAwareness phase predicates#4134

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
kridaydave:fix/agentawareness-dead-code
Jul 19, 2026
Merged

fix(shared): delete unused agentAwareness phase predicates#4134
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
kridaydave:fix/agentawareness-dead-code

Conversation

@kridaydave

@kridaydave kridaydave commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Removed isTerminalAgentAwarenessPhase and isInterruptiveAgentAwarenessPhase from agentAwareness.ts.

They had zero importers across the repo. Removing only the export left private-unused dead code that failed lint, so the functions are deleted entirely.

vp lint passes clean.


Note

Low Risk
Pure removal of unused exports with no call sites; no behavior or API surface used elsewhere is affected.

Overview
Removes isTerminalAgentAwarenessPhase and isInterruptiveAgentAwarenessPhase from packages/shared/src/agentAwareness.ts. Neither helper had any importers in the repo, so this is dead-code cleanup only; projectThreadAwareness and phase resolution logic are unchanged.

Reviewed by Cursor Bugbot for commit 9f7344d. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove unused isTerminalAgentAwarenessPhase and isInterruptiveAgentAwarenessPhase exports

Deletes two unused predicate functions from agentAwareness.ts. No callers reference these exports, so removal has no runtime impact.

Macroscope summarized 9f7344d.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a21552c9-ecd8-4c8d-af39-3a85c99a2409

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jul 18, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Deletes two utility functions confirmed unused anywhere in the codebase. No runtime behavior change.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit e8ff6bc into pingdotgg:main Jul 19, 2026
16 checks passed
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 20, 2026
pingdotgg#4112, pingdotgg#4132, pingdotgg#4134, pingdotgg#4006, pingdotgg#4137) (#171)

* [codex] Route OpenCode missing-session errors through Effect (pingdotgg#3608)

Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit d0b9f8d)

* [codex] canonicalize client timestamps (pingdotgg#4112)

(cherry picked from commit da3c203)

* fix: increase OpenCode server startup timeout from 5s to 30s (pingdotgg#4132)

(cherry picked from commit 398140a)

* fix(shared): delete unused agentAwareness phase predicates (pingdotgg#4134)

(cherry picked from commit e8ff6bc)

* perf(client): defer active thread cache writes (pingdotgg#4006)

(cherry picked from commit 765e1b5)

* fix(client): use lightweight connection probe (pingdotgg#4137)

(cherry picked from commit 2640e6d)

* fix(client): adapt deferred thread cache tests for fork warm-cache

Fork warm-cache seeding stays on synchronizing and must not re-persist
active turns. Gate the seed persistence write with shouldPersistThread
and drive the pingdotgg#4006 regression test to live via a socket snapshot.

Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>

---------

Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Maxwell Young <maxtheyoung@gmail.com>
Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: Kriday Dave <technocratix902@gmail.com>
Co-authored-by: Chris Michael Guzman <67719167+Chrrxs@users.noreply.github.com>
Co-authored-by: eeinarsson <128746408+eeinarsson@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Jul 20, 2026
…ingdotgg#3749, pingdotgg#4159) (#172)

* [codex] Route OpenCode missing-session errors through Effect (pingdotgg#3608)

Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit d0b9f8d)

* [codex] canonicalize client timestamps (pingdotgg#4112)

(cherry picked from commit da3c203)

* fix: increase OpenCode server startup timeout from 5s to 30s (pingdotgg#4132)

(cherry picked from commit 398140a)

* fix(shared): delete unused agentAwareness phase predicates (pingdotgg#4134)

(cherry picked from commit e8ff6bc)

* perf(client): defer active thread cache writes (pingdotgg#4006)

(cherry picked from commit 765e1b5)

* fix(client): use lightweight connection probe (pingdotgg#4137)

(cherry picked from commit 2640e6d)

* fix(client): adapt deferred thread cache tests for fork warm-cache

Fork warm-cache seeding stays on synchronizing and must not re-persist
active turns. Gate the seed persistence write with shouldPersistThread
and drive the pingdotgg#4006 regression test to live via a socket snapshot.

Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>

* feat(web): themed sidebar header art for nightly and dev builds (pingdotgg#4130)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
(cherry picked from commit 53e3c98)

* feat: add headless `t3 connect` setup for SSH hosts (pingdotgg#3749)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 7a820ab)

* Refine T3 Connect authorization surfaces (pingdotgg#4159)

Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 2b180a2)

---------

Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Maxwell Young <maxtheyoung@gmail.com>
Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: Kriday Dave <technocratix902@gmail.com>
Co-authored-by: Chris Michael Guzman <67719167+Chrrxs@users.noreply.github.com>
Co-authored-by: eeinarsson <128746408+eeinarsson@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: maria <maria@kuuro.net>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: codex <codex@users.noreply.github.com>
adamfgr pushed a commit to agriffiths-bots/t3code that referenced this pull request Jul 20, 2026
* Add isolated app testing workflow (pingdotgg#4121)

Co-authored-by: codex <codex@users.noreply.github.com>

* feat(web): themed sidebar header art for nightly and dev builds (pingdotgg#4130)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <jmarminge@gmail.com>

* feat: add headless `t3 connect` setup for SSH hosts (pingdotgg#3749)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>

* Refine T3 Connect authorization surfaces (pingdotgg#4159)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix: increase OpenCode server startup timeout from 5s to 30s (pingdotgg#4132)

* fix(shared): delete unused agentAwareness phase predicates (pingdotgg#4134)

* fix(mobile): Stabilize native stack option updates (pingdotgg#4037)

Co-authored-by: codex <codex@users.noreply.github.com>

* Make test-t3-app skill discoverable by Claude Code (pingdotgg#4162)

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

* fix(web): improve dev sidebar backdrop contrast & remove version pills (pingdotgg#4166)

* Fix draft banner stack overlap (pingdotgg#4164)

Co-authored-by: codex <codex@users.noreply.github.com>

* Add portable mobile app testing guidance (pingdotgg#4165)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(client): use lightweight connection probe (pingdotgg#4137)

---------

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: maria <maria@kuuro.net>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: Kriday Dave <technocratix902@gmail.com>
Co-authored-by: eeinarsson <128746408+eeinarsson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants