chore: sync upstream pingdotgg/t3code (20260720)#213
Merged
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
…dotgg#4130) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d4e310aeb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly sync of upstream
pingdotgg/t3code(12 commits, cherry-picked since1735e27d).Synced commits
2640e6dcffix(client): use lightweight connection probe (fix(client): use lightweight connection probe pingdotgg/t3code#4137)e34250df4Add portable mobile app testing guidance (Add portable mobile app testing guidance pingdotgg/t3code#4165)7e1a0d551Fix draft banner stack overlap (Fix draft banner stack overlap pingdotgg/t3code#4164)b511227b7fix(web): improve dev sidebar backdrop contrast & remove version pills (fix(web): improve dev sidebar backdrop contrast & remove version pills pingdotgg/t3code#4166)69c8be2eeMake test-t3-app skill discoverable by Claude Code (Make test-t3-app skill discoverable by Claude Code pingdotgg/t3code#4162)271454cbdfix(mobile): Stabilize native stack option updates (fix(mobile): Stabilize native stack option updates pingdotgg/t3code#4037)e8ff6bc7ffix(shared): delete unused agentAwareness phase predicates (fix(shared): delete unused agentAwareness phase predicates pingdotgg/t3code#4134)398140a9bfix: increase OpenCode server startup timeout from 5s to 30s (fix: increase OpenCode server startup timeout from 5s to 30s pingdotgg/t3code#4132)2b180a2b2Refine T3 Connect authorization surfaces (Refine T3 Connect authorization surfaces pingdotgg/t3code#4159)7a820abfdfeat: add headlesst3 connectsetup for SSH hosts (feat: add headlesst3 connectsetup for SSH hosts pingdotgg/t3code#3749)53e3c98a5feat(web): themed sidebar header art for nightly and dev builds (feat(web): themed sidebar header art for nightly and dev builds pingdotgg/t3code#4130)4f1174051Add isolated app testing workflow (Add isolated app testing workflow pingdotgg/t3code#4121)Conflict resolution (the only surface this merge could introduce a bug in)
apps/web/src/components/Sidebar.tsx— import-block collision. Kept both: fork'sisProjectNotEmptyInvariantand upstream'sSidebarStageBackdrop.apps/web/src/hostedPairing.ts— upstream movedDEFAULT_HOSTED_APP_URLinto@t3tools/shared/connectAuth(same value,https://app.t3.codes). Dropped the now-duplicate local const, kept upstream'spairingUrlimport and the fork-local Cloudflare Pages host constants.apps/server/vite.config.ts— union ofpack.defineentries: fork's__T3CODE_BUILD_SHA__/__T3CODE_BUILD_VERSION__plus upstream's__T3CODE_BUILD_CHANNEL__..claude/skills— upstream (Make test-t3-app skill discoverable by Claude Code pingdotgg/t3code#4162) replaces the directory with a symlink to../.agents/skills; the fork keeps real skill content there (linear-issue-fix,report-t3-bug,t3-e2e-testing,t3-test-server). Resolved by keeping the fork directory and adding a per-skill symlink.claude/skills/test-t3-app -> ../../.agents/skills/test-t3-app, which achieves upstream's discoverability goal without dropping fork skills.apps/server/src/ws.ts— union in both the RPC scope map and the handler map: fork's scheduled-task methods (subscribeScheduledTasks,setScheduledTaskEnabled,deleteScheduledTask) alongside upstream's newserverProbe.packages/client-runtime/src/rpc/session.ts— upstream renamedmapInitialConfigError->mapSessionRpcErrorand widened its input toInitialConfigError | ProbeError. Took upstream's version; preserved the fork'sHeaderOptionsWebSocketConstructortype (still used at line 110).No fork production code needed changes: model routing stays registry-driven.
Verification
vp run typecheck— cleanvp check— 0 errors (1 pre-existing lint warning inSidebarUpdatePill.tsx, unchanged from the 20260718 sync)vp test run— 689 files / 6190 tests passed, 0 failuresPer the fork's upstream-sync policy, Codex findings in files outside the conflicted set above are upstream-origin and accepted as-is.